Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 6 pull requests #28051

Closed
wants to merge 23 commits into from
Closed

Rollup of 6 pull requests #28051

wants to merge 23 commits into from

Conversation

Manishearth
Copy link
Member

GuillaumeGomez and others added 23 commits August 26, 2015 13:13
@GuillaumeGomez
Improve E0046
dddc4ca
@GuillaumeGomez
Improve E0062 error explanation
9e51cee
@GuillaumeGomez
Improve E0063 error explanation
612221f
@GuillaumeGomez
Improve E0025 error explanation
5d8dc90
@GuillaumeGomez
Fix typo in E0087
af02bcc
@GuillaumeGomez
Add erroneous code example for E0131
0c4faf2
@GuillaumeGomez
Add missing ';' in E0132
9f15b28
@GuillaumeGomez
Remove unnecessary whitespace
dfb0677
@GuillaumeGomez
Remove unnecessary empty lines
805e4e6
@GuillaumeGomez
Add E0370 error explanation
acafe3b
@artemshitov
Fix keyboard scrolling in rustbook
c891fae
@artemshitov
Remove redundant overflowing rule
b392016
@tshepang
path: the if-else block looked unusual
933eb3e
@birkenfeld
core: Implement IntoIterator for Option and Result references
a7313a0 
Fixes rust-lang#27996.
@GuillaumeGomez
Comment out unused error codes in librustc_typeck/diagnostics.rs
fbbd874
@apasel422
remove calls to deprecated iter::order functions
21f209a
@steveklabnik
Some extra examples for the unimplemented! macro
59653c1
@Manishearth
Rollup merge of rust-lang#28010 - GuillaumeGomez:patch-2, r=Manishearth
886ea16 
r? @Manishearth
@Manishearth
Rollup merge of rust-lang#28013 - artemshitov:rustbook-scrolling, r=s…
bf517fd 
…teveklabnik

As of now, when you open a page in the Rust book and other books made with `rustbook`, you cannot scroll with your keyboard, whether using spacebar or arrow keys, unless you explicitly focus on the content div by clicking.

This PR fixes the issue by removing the bound on the content div size and by sticking the TOC with `position: fixed` rather than restricting the content to the window height.

r? @steveklabnik
@Manishearth
Rollup merge of rust-lang#28029 - tshepang:unusual, r=steveklabnik
4d975c9
@Manishearth
Rollup merge of rust-lang#28039 - birkenfeld:option_result_ref_intoit…
51cc430 
…er, r=alexcrichton

Fixes rust-lang#27996.

Does this need any `#[stable]`/`#[unstable]` attributes?
@Manishearth
Rollup merge of rust-lang#28045 - apasel422:iter, r=sfackler
4b1967c
@Manishearth
Rollup merge of rust-lang#28048 - steveklabnik:doc_unimplemented, r=a…
fe7a8a4 
…lexcrichton
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
rollup A PR which is a rollup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Manishearth @rust-highfive @nikomatsakis @Centril @GuillaumeGomez @artemshitov @tshepang @birkenfeld @apasel422 @steveklabnik