Disable browser history API on file:/// URLs #28400
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@badboy you should probably squash your commits. That's what is normally wanted if your pull request is left sitting for a long time. (I'm not a Collaborator or an Owner, so I don't know, but that is what happened to me a few times) |
|
It's just a few hours yet. I happily squash them though. |
| @@ -54,7 +54,8 @@ | |||
| } | |||
|
|
|||
| function browserSupportsHistoryApi() { | |||
| return window.history && typeof window.history.pushState === "function"; | |||
| return document.origin != "null" && | |||
There was a problem hiding this comment.
document.origin doesn't seem to be well-supported: https://developer.mozilla.org/en-US/docs/Web/API/Document/origin
There was a problem hiding this comment.
Looks like document.defaultView.location.origin might be the compatible way?
There was a problem hiding this comment.
Interesting, and I thought this was the standard. I will update & test in Firefox as well.
history.pushState is defined, but not working whenever document.origin is "null" (literally that string, not just the null object). This is due to some security considerations and is unlikely to be ever working. For now just disable the usage of the history API when the documentation is accessed through a file:/ URL. See https://code.google.com/p/chromium/issues/detail?id=301210 for a Chrome-specific issue on the history API on file:/ URLs Closes rust-lang#25953
badboy
force-pushed
the
disable-browser-history-on-file
branch
from
493e1c9 to
7f5ec6c
Compare
|
force-pushed, now using |
|
@bors: r+ rollup |
|
📌 Commit 7f5ec6c has been approved by |
…ile, r=steveklabnik history.pushState is defined, but not working whenever document.origin is "null" (literally that string, not just the null object). This is due to some security considerations and is unlikely to be ever working. For now just disable the usage of the history API when the documentation is accessed through a file:/// URL. See https://code.google.com/p/chromium/issues/detail?id=301210 for a Chrome-specific issue on the history API on file:/// URLs Closes rust-lang#25953
history.pushState is defined, but not working whenever document.origin is "null"
(literally that string, not just the null object).
This is due to some security considerations and is unlikely to be ever working.
For now just disable the usage of the history API when the documentation
is accessed through a file:/// URL.
See https://code.google.com/p/chromium/issues/detail?id=301210 for a
Chrome-specific issue on the history API on file:/// URLs
Closes #25953