Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anchors in error docs #28496

Merged
merged 8 commits into from
Sep 19, 2015
Merged

Conversation

davidszotten
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bors
Copy link
Collaborator

bors commented Sep 18, 2015

☔ The latest upstream changes (presumably #28492) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member

Looks like this might need a rebase? Other than though looks good to me!

@steveklabnik
Copy link
Member

Same! r=me after it applies cleanly.

@davidszotten
Copy link
Contributor Author

found a bunch more missing references. what are your thoughts on getting a checker for this into the test suite?

@steveklabnik
Copy link
Member

That'd be great.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 19, 2015

📌 Commit 5ab3058 has been approved by steveklabnik

@steveklabnik
Copy link
Member

Oh, by the way: in the future, please leave a comment after you rebase, as we don't get notified when new commits are pushed :/

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Sep 19, 2015
bors added a commit that referenced this pull request Sep 19, 2015
@bors bors merged commit 5ab3058 into rust-lang:master Sep 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants