-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix anchors in error docs #28496
Fix anchors in error docs #28496
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
☔ The latest upstream changes (presumably #28492) made this pull request unmergeable. Please resolve the merge conflicts. |
Looks like this might need a rebase? Other than though looks good to me! |
Same! r=me after it applies cleanly. |
283d162
to
f7d8b41
Compare
found a bunch more missing references. what are your thoughts on getting a checker for this into the test suite? |
That'd be great. |
@bors: r+ rollup |
📌 Commit 5ab3058 has been approved by |
Oh, by the way: in the future, please leave a comment after you rebase, as we don't get notified when new commits are pushed :/ |
No description provided.