Don't crash on non-existent path in constant. #28686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| // FIXME: There's probably a better way to make sure we don't | ||
| // panic here. | ||
| if def.depth != 0 { | ||
| signal!(e, NonConstPath); |
There was a problem hiding this comment.
You could extend the error enum to have a specific variant for this situation, as NonConstPath signifies a valid but not constant path imo
|
☔ The latest upstream changes (presumably #28702) made this pull request unmergeable. Please resolve the merge conflicts. |
The behavior here isn't really ideal, but we can't really do much better given the current state of constant evaluation. Fixes rust-lang#28670, and probably a bunch of duplicates.
eefriedman
force-pushed
the
unresolved-path-error
branch
from
cc743f1 to
1763fcb
Compare
|
Updated with a new error kind and better comments. |
|
@bors r+ rollup |
|
📌 Commit 1763fcb has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Oct 1, 2015
…=nikomatsakis The behavior here isn't really ideal, but we can't really do much better given the current state of constant evaluation. The changes to ExprUseVisitor are to avoid a compile error; apparently that bit of code is extremely sensitive to changes in other areas of the compiler. Fixes rust-lang#28670, and probably a bunch of duplicates.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 2, 2015
…=nikomatsakis The behavior here isn't really ideal, but we can't really do much better given the current state of constant evaluation. The changes to ExprUseVisitor are to avoid a compile error; apparently that bit of code is extremely sensitive to changes in other areas of the compiler. Fixes rust-lang#28670, and probably a bunch of duplicates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior here isn't really ideal, but we can't really do much better
given the current state of constant evaluation.
The changes to ExprUseVisitor are to avoid a compile error; apparently
that bit of code is extremely sensitive to changes in other areas of the
compiler.
Fixes #28670, and probably a bunch of duplicates.