Skip to content

Use the correct mod name from the example #28836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2015
Merged

Use the correct mod name from the example #28836

merged 1 commit into from
Oct 8, 2015

Conversation

id4ho
Copy link
Contributor

@id4ho id4ho commented Oct 4, 2015

@steveklabnik
Copy link
Member

Why is this change needed? "Cleanup" is too vague.

@id4ho id4ho changed the title Name cleanup Use the correct mod name from the example Oct 5, 2015
@id4ho
Copy link
Contributor Author

id4ho commented Oct 5, 2015

@steveklabnik, you're right, sorry about that. I updated the title.

This change is not really a clean up so much as making the explanation match the state of the example.

In the first use statement (in the example above the change) we import the japanese::greetings module not the japanese::farewells module.

@steveklabnik
Copy link
Member

Ah thanks! I see now. Would you mind doing a quick amend of the commit message too, so that the history reflects this info, not just the PR? Happy to merge this after.

@id4ho
Copy link
Contributor Author

id4ho commented Oct 7, 2015

@steveklabnik sure thing, commit message updated! Sorry for the delay.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 7, 2015

📌 Commit d21b4f5 has been approved by steveklabnik

@steveklabnik
Copy link
Member

No worries :) Thanks for the patch!

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 7, 2015
@steveklabnik
Rollup merge of rust-lang#28836 - jackwilsonv:patch-6, r=steveklabnik
a5f3f89 
r? @steveklabnik
@steveklabnik steveklabnik mentioned this pull request Oct 7, 2015
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 7, 2015
@steveklabnik
Rollup merge of rust-lang#28836 - jackwilsonv:patch-6, r=steveklabnik
18c66b5 
r? @steveklabnik
@steveklabnik steveklabnik mentioned this pull request Oct 7, 2015
Merged
bors added a commit that referenced this pull request Oct 8, 2015
@bors
Auto merge of #28897 - steveklabnik:rollup, r=steveklabnik
b75fe81 
- Successful merges: #28836, #28856, #28874, #28876, #28878, #28880, #28882, #28885, #28889, #28896
- Failed merges:
@bors bors merged commit d21b4f5 into rust-lang:master Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@id4ho @steveklabnik @bors