Skip to content

trpl: Few minor fixes (wording, formatting) #28889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2015
Merged

Conversation

JIghtuse
Copy link
Contributor

@JIghtuse JIghtuse commented Oct 7, 2015

No description provided.

Later in text we mention 'step four' and 'step three'. This fix releases user
from counting.
@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@JIghtuse
Copy link
Contributor Author

JIghtuse commented Oct 7, 2015

r? @steveklabnik

@rust-highfive rust-highfive assigned steveklabnik and unassigned brson Oct 7, 2015
@@ -42,12 +42,12 @@ loop is just a handy way to write this `loop`/`match`/`break` construct.
`for` loops aren't the only thing that uses iterators, however. Writing your
own iterator involves implementing the `Iterator` trait. While doing that is
outside of the scope of this guide, Rust provides a number of useful iterators
to accomplish various tasks. Before we talk about those, we should talk about a
Rust anti-pattern. And that's using ranges like this.
to accomplish various tasks. But first, few notes about limitations of ranges.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "a few notes"

@steveklabnik
Copy link
Member

Thanks a ton! Just a few nits

@JIghtuse
Copy link
Contributor Author

JIghtuse commented Oct 7, 2015

Ok, amended them.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 7, 2015

📌 Commit 1e0fbbd has been approved by steveklabnik

@steveklabnik
Copy link
Member

Thank you!

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 7, 2015
bors added a commit that referenced this pull request Oct 8, 2015
@bors bors merged commit 1e0fbbd into rust-lang:master Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants