Move fail upcall into rust #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to #2861. |
|
How will this affect breaking on fail in gdb? |
|
In this patch rust's rt::fail is still a wrapper around C, so you will still be able to break on the C upcall_fail if you want. In the future, the plan is to get rid of upcall_fail (and the entire upcall stack switching path), so you'll have to break on rt::fail just like you'd break on any other rust function. I believe that should still work fine, as long as you have debugging symbols. |
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
May 11, 2023
Update to latest ui_test crate version. Also stops using github actions groups that conflict with our groups as github does not nest them
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Upgrade version number to 0.41.0 The CHANGELOG changes are: ``` # What's Changed * Fix setup for `aarch64-unknown-linux-gnu` platform by @adpaco-aws in model-checking/kani#2864 * Do not override `std` library during playback by @celinval in model-checking/kani#2852 * Fix docker build step in release workflow by @adpaco-aws in model-checking/kani#2854 * Fix path-dependent failures in `assess-artifacts` test by @adpaco-aws in model-checking/kani#2849 * Automatic toolchain upgrade to nightly-2023-11-11 by @github-actions in model-checking/kani#2870 **Full Changelog**: model-checking/kani@kani-0.40.0...kani-0.41.0 ### Breaking Changes * Set minimum python to 3.7 in docker container and release action by @remi-delmas-3000 in model-checking/kani#2879 * Delete `any_slice` which has been deprecated since Kani 0.38.0. by @zhassan-aws in model-checking/kani#2860 ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the fail upcall into rust libcore. I added a core::rt module for rust runtime calls ("rtcalls"), added a pass to trans to gather the new rtcalls into the crate_ctxt, and changed trans_fail_value to emit calls to rust.