Generate stability attributes for derived impls #29152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The attributes are copied from the item for which the trait impl is derived
|
⌛ Testing commit 629c2a8 with merge db54339... |
bors
added a commit
that referenced
this pull request
Oct 20, 2015
The attributes are copied from the item for which the trait impl is derived I think now we can close these two issues: #13054 - `allow`, `deny` etc. were already copied, now `stable` and `unstable` are copied as well. #18969 - I'm not sure this is needed, insta-stability were good enough so far, copied stability will be better. Nonetheless, it can be subsumed by some more general mechanism for supplying arbitrary not necessarily stability related attributes (for example `inline`) to derived impls and their methods (I haven't found an open issue for such mechanism). r? @alexcrichton
This was referenced Nov 27, 2015
petrochenkov
referenced
this pull request
in petrochenkov/rust
Dec 14, 2015
jyn514
added
A-attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attributes are copied from the item for which the trait impl is derived
I think now we can close these two issues:
#13054 -
allow,denyetc. were already copied, nowstableandunstableare copied as well.#18969 - I'm not sure this is needed, insta-stability were good enough so far, copied stability will be better. Nonetheless, it can be subsumed by some more general mechanism for supplying arbitrary not necessarily stability related attributes (for example
inline) to derived impls and their methods (I haven't found an open issue for such mechanism).r? @alexcrichton