Skip to content

src/doc/trpl -> src/doc/book #29932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2015
Merged

src/doc/trpl -> src/doc/book #29932

merged 1 commit into from
Nov 19, 2015

Conversation

steveklabnik
Copy link
Member

The book was located under 'src/doc/trpl' because originally, it was
going to be hosted under that URL. Late in the game, before 1.0, we
decided that /book was a better one, so we changed the output, but
not the input. This causes confusion for no good reason. So we'll change
the source directory to look like the output directory, like for every
other thing in src/doc.

r? @brson

The book was located under 'src/doc/trpl' because originally, it was
going to be hosted under that URL. Late in the game, before 1.0, we
decided that /book was a better one, so we changed the output, but
not the input. This causes confusion for no good reason. So we'll change
the source directory to look like the output directory, like for every
other thing in src/doc.
@brson
Copy link
Contributor

brson commented Nov 19, 2015

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 19, 2015

📌 Commit 024aa9a has been approved by brson

@bors
Copy link
Collaborator

bors commented Nov 19, 2015

⌛ Testing commit 024aa9a with merge fd688f4...

bors added a commit that referenced this pull request Nov 19, 2015
The book was located under 'src/doc/trpl' because originally, it was
going to be hosted under that URL. Late in the game, before 1.0, we
decided that /book was a better one, so we changed the output, but
not the input. This causes confusion for no good reason. So we'll change
the source directory to look like the output directory, like for every
other thing in src/doc.

r? @brson
@tshepang
Copy link
Member

💃

@liigo
Copy link
Contributor

liigo commented Nov 27, 2015

Nice work. I suggested changing this one year ago.

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Nov 30, 2015
In rust-lang#29932, I moved the location of TRPL, but I missed making the changes
in mk/tests.mk. This led to rust-lang#30088 landing with a broken example.

As such, rust-lang#30113 will need to land before this.
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Nov 30, 2015
bors added a commit that referenced this pull request Nov 30, 2015
In #29932, I moved the location of TRPL, but I missed making the changes
in mk/tests.mk. This led to #30088 landing with a broken example.

As such, #30113 will need to land before this.
@steveklabnik steveklabnik deleted the trpl_book branch June 19, 2016 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants