Skip to content

Re-enable testing the book #30121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2015
Merged

Conversation

steveklabnik
Copy link
Member

In #29932, I moved the location of TRPL, but I missed making the changes
in mk/tests.mk. This led to #30088 landing with a broken example.

As such, #30113 will need to land before this.

In rust-lang#29932, I moved the location of TRPL, but I missed making the changes
in mk/tests.mk. This led to rust-lang#30088 landing with a broken example.

As such, rust-lang#30113 will need to land before this.
@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ 1a2d1b8

I'm gonna r+ this, and feel free to do whatever to land it (I'm never a huge fan of requiring ordering between PRs)

@steveklabnik
Copy link
Member Author

The other one is already being tested, so it should Just Work (tm)

@steveklabnik
Copy link
Member Author

@bors: p=100

the needed PR has passed, let's land this ASAP to prevent any further regression

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Nov 30, 2015
bors added a commit that referenced this pull request Nov 30, 2015
In #29932, I moved the location of TRPL, but I missed making the changes
in mk/tests.mk. This led to #30088 landing with a broken example.

As such, #30113 will need to land before this.
@bors
Copy link
Collaborator

bors commented Nov 30, 2015

⌛ Testing commit 1a2d1b8 with merge a2866e3...

@Gankra
Copy link
Contributor

Gankra commented Nov 30, 2015

Shame camel, Steve.

🐫

@bors bors merged commit 1a2d1b8 into rust-lang:master Dec 1, 2015
@steveklabnik steveklabnik deleted the fix_trpl_tests branch June 19, 2016 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants