-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Re-enable testing the book #30121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Re-enable testing the book #30121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rust-lang#29932, I moved the location of TRPL, but I missed making the changes in mk/tests.mk. This led to rust-lang#30088 landing with a broken example. As such, rust-lang#30113 will need to land before this.
(rust_highfive has picked a reviewer for you, use r? to override) |
The other one is already being tested, so it should Just Work (tm) |
@bors: p=100 the needed PR has passed, let's land this ASAP to prevent any further regression |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Nov 30, 2015
…hearth Along with rust-lang#30121, this should fix the last fallout from rust-lang#29932
Shame camel, Steve. 🐫 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #29932, I moved the location of TRPL, but I missed making the changes
in mk/tests.mk. This led to #30088 landing with a broken example.
As such, #30113 will need to land before this.