AsRawHandle IntoRawHandle and JoinHandleExt for JoinHandle #30177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retep998
force-pushed
the
handling-threads
branch
2 times, most recently
from
a252dc7 to
79bc94e
Compare
| @@ -25,6 +25,8 @@ use os::unix::raw::{uid_t, gid_t}; | |||
| #[stable(feature = "raw_ext", since = "1.1.0")] pub type off_t = i64; | |||
| #[stable(feature = "raw_ext", since = "1.1.0")] pub type time_t = i64; | |||
|
|
|||
| #[unstable(feature = "pthread_t", issue = "0")] pub type pthread_t = usize; | |||
There was a problem hiding this comment.
Could you connect all these issues to the same tracking issue as below? (#29791)
|
Thanks! Just one nit and otherwise r=me |
retep998
force-pushed
the
handling-threads
branch
from
79bc94e to
9376f70
Compare
|
Addressed nit. |
|
@bors: r+ 9376f707524f291021a5621ae7dccf20db996027 Thanks! |
|
⌛ Testing commit 9376f70 with merge 71fd63f... |
|
💔 Test failed - auto-win-msvc-64-opt |
| // except according to those terms. | ||
|
|
||
| //! Extensions to `std::thread` for Windows. | ||
|
|
There was a problem hiding this comment.
Oh dang, I need a stability attribute here. Which feature do I use?
There was a problem hiding this comment.
It's fine to leave the module unstable (there's actually no need for it to be public), and just point it to the same pthread_t issue.
This allows users to get the HANDLE of a spawned thread on Windows Signed-off-by: Peter Atashian <retep998@gmail.com>
Signed-off-by: Peter Atashian <retep998@gmail.com>
retep998
force-pushed
the
handling-threads
branch
from
9376f70 to
9749a19
Compare
|
Added that missing stability attribute. |
bors
added a commit
that referenced
this pull request
Dec 5, 2015
Allows a `HANDLE` to be extracted from a `JoinHandle` on Windows. Allows a `pthread_t` to be extracted from a `JoinHandle` everywhere else. Because #29461 was closed. r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a
HANDLEto be extracted from aJoinHandleon Windows.Allows a
pthread_tto be extracted from aJoinHandleeverywhere else.Because #29461 was closed.
r? @alexcrichton