mk: actually run valgrind on x86_64-apple-darwin #30365

tamird · 2015-12-13T15:54:15Z

Since darwin is really apple-darwin, the valgrind-rpass tests were not actually being run with valgrind on mac before. Also, the HOST check was completely wrong.

r? @alexcrichton

alexcrichton · 2015-12-13T19:05:19Z

@bors: r+ 952348e39e18aee1f98cccc6ebd596911c0d822d

Hey if it gets past the bots that sounds good to me. Thanks!

bors · 2015-12-14T01:27:45Z

⌛ Testing commit 952348e with merge e0836e9...

bors · 2015-12-14T01:33:57Z

💔 Test failed - auto-mac-32-opt

tamird · 2015-12-14T15:38:51Z

Needs a retry

pnkfelix · 2015-12-14T15:43:41Z

@bors retry

tamird · 2015-12-16T13:01:48Z

Can I get another retry? bors seems to have dropped this.

alexcrichton · 2015-12-16T16:09:39Z

@bors: retry

pnkfelix · 2015-12-17T10:54:33Z

@bors force retry

(Is force still a thing?)

update: ((oh wait, it is in the queue, maybe that was unnecessary...))

Manishearth · 2015-12-18T11:17:57Z

http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/7436/steps/test/logs/stdio

tamird · 2015-12-18T12:00:17Z

One of the failures is https://bugs.kde.org/show_bug.cgi?id=201216; can we get valgrind updated on the mac bots? This was fixed in 3.11 (see http://valgrind.org/docs/manual/dist.news.html).

I've updated for the other failures.

- Successful merges: #30272, #30286, #30365, #30381, #30384, #30398, #30406, #30408, #30420, #30431, #30447, #30452 - Failed merges:

alexcrichton · 2015-12-18T17:22:04Z

I'm actually not sure the mac bots will be guaranteed to actually run newer versions of valgrind, they're all running older OSX versions (e.g. 10.7 or 10.8).

I've always thought that valgrind was a little sketchy on OSX?

tamird · 2015-12-18T18:58:29Z

It's sketchy, but it works (I think). We do have special OS X suppressions,
but otherwise things should be workable with 3.11.
On Dec 18, 2015 12:23, "Alex Crichton" notifications@github.com wrote:

I'm actually not sure the mac bots will be guaranteed to actually run
newer versions of valgrind, they're all running older OSX versions (e.g.
10.7 or 10.8).

I've always thought that valgrind was a little sketchy on OSX?

—
Reply to this email directly or view it on GitHub
#30365 (comment).

alexcrichton · 2015-12-18T21:53:19Z

Unfortunately it's actually pretty nontrivial to upgrade valgrind right now on the OSX bots, can this land without doing that?

tamird · 2015-12-18T22:00:33Z

I suppose if we disabled run-pass-valgrind/exit-flushes.rs on OS X, then we could land this. Does that sound worth it?

alexcrichton · 2015-12-18T22:04:20Z

Yeah I think that'd be fine. Hopefully when we move to macstadium it should be easy to upgrade to a new valgrind (and have macs that are consistently online...)

tamird · 2015-12-19T01:16:22Z

OK, done! I'll be offline for the next week or so; I'll circle back and address comments if this doesn't land by then.

Happy holidays!

alexcrichton · 2015-12-19T18:19:00Z

@bors: r+ 3f054b3ad53e7c97423f8002de56b9464f7051ed

tamird · 2015-12-24T00:54:12Z

Updated to suppress this one.

On Sun, Dec 20, 2015 at 7:40 AM, Felix S Klock II notifications@github.com
wrote:

Error message looks legit:

failures:

---- [run-pass-valgrind] run-pass-valgrind/osx-frameworks.rs stdout ----

error: test run failed!
status: exit code: 100
command: /usr/local/bin/valgrind --error-exitcode=100 --fair-sched=try --quiet --soname-synonyms=somalloc=NONE --suppressions=/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/etc/x86.supp --suppressions=/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/etc/apple-darwin.supp --tool=memcheck --leak-check=full x86_64-apple-darwin/test/run-pass-valgrind/osx-frameworks.stage2-x86_64-apple-darwin

stdout:

stderr:

==42057== 1,040 bytes in 1 blocks are possibly lost in loss record 337 of 352
==42057== at 0x6DDC: malloc_zone_malloc (in /usr/local/Cellar/valgrind/3.10.0/lib/valgrind/vgpreload_memcheck-amd64-darwin.so)
==42057== by 0xA5C293: NXCreateMapTableFromZone (in /usr/lib/libobjc.A.dylib)
==42057== by 0xA6FD40: nonMetaClasses() (in /usr/lib/libobjc.A.dylib)
==42057== by 0xA61537: objc_registerClassPair (in /usr/lib/libobjc.A.dylib)
==42057== by 0x96A68: __CFMakeNSBlockClasses (in /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation)
==42057== by 0x7E98E: __CFInitialize (in /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation)
==42057== by 0x7FFF5FC13255: ImageLoaderMachO::doImageInit(ImageLoader::LinkContext const&) (in /usr/lib/dyld)
==42057== by 0x7FFF5FC13756: ImageLoaderMachO::doInitialization(ImageLoader::LinkContext const&) (in /usr/lib/dyld)
==42057== by 0x7FFF5FC1006D: ImageLoader::recursiveInitialization(ImageLoader::LinkContext const&, unsigned int, ImageLoader::InitializerTimingList&) (in /usr/lib/dyld)
==42057== by 0x7FFF5FC0FFC3: ImageLoader::recursiveInitialization(ImageLoader::LinkContext const&, unsigned int, ImageLoader::InitializerTimingList&) (in /usr/lib/dyld)
==42057== by 0x7FFF5FC0FEB9: ImageLoader::runInitializers(ImageLoader::LinkContext const&, ImageLoader::InitializerTimingList&) (in /usr/lib/dyld)
==42057== by 0x7FFF5FC01FBF: dyld::initializeMainExecutable() (in /usr/lib/dyld)
==42057==

thread '[run-pass-valgrind] run-pass-valgrind/osx-frameworks.rs' panicked at 'explicit panic', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/compiletest/runtest.rs:1505

—
Reply to this email directly or view it on GitHub
#30365 (comment).

pnkfelix · 2015-12-24T22:04:27Z

@bors r+ c1e12e8

bors · 2015-12-24T22:04:28Z

🙀 c1e12e8 is not a valid commit SHA. Please try again with c1e12e0.

pnkfelix · 2015-12-24T22:04:40Z

@bors r+ c1e12e0

bors · 2015-12-25T11:22:58Z

⌛ Testing commit c1e12e0 with merge 7d7856b...

bors · 2015-12-25T11:51:34Z

⛄ The build was interrupted to prioritize another pull request.

bors · 2015-12-25T12:48:11Z

⌛ Testing commit c1e12e0 with merge 8367140...

bors · 2015-12-25T13:53:36Z

💔 Test failed - auto-mac-64-nopt-t

tamird · 2015-12-25T20:51:06Z

Tidy error. Fixed.

On Fri, Dec 25, 2015 at 8:54 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/7544

—
Reply to this email directly or view it on GitHub
#30365 (comment).

tamird · 2015-12-28T10:53:54Z

ping @pnkfelix

pnkfelix · 2015-12-29T14:21:49Z

@bors r+ a3d81c6

bors · 2015-12-30T04:20:32Z

⌛ Testing commit a3d81c6 with merge 302010d...

bors · 2015-12-30T05:53:59Z

💔 Test failed - auto-linux-64-opt

pnkfelix · 2015-12-30T16:57:26Z

@bors retry

bors · 2015-12-30T17:59:51Z

⌛ Testing commit a3d81c6 with merge 09f7c10...

bors · 2015-12-30T19:37:52Z

💔 Test failed - auto-linux-64-opt

tamird · 2015-12-30T20:40:56Z

Needs another retry :(

@alexcrichton

Since `darwin` is really `apple-darwin`, the valgrind-rpass tests were not actually being run with valgrind on mac before. Also, the `HOST` check was completely wrong. r? @alexcrichton

- Successful merges: #30365, #30565, #30590, #30630 - Failed merges:

rust-highfive assigned alexcrichton Dec 13, 2015

Manishearth mentioned this pull request Dec 18, 2015

Rollup of 12 pull requests #30457

Merged

mk: actually run valgrind on x86_64-apple-darwin

928e3e4

tamird force-pushed the update-valgrind branch from 952348e to b9689f4 Compare December 18, 2015 12:00

bors added a commit that referenced this pull request Dec 18, 2015

Auto merge of #30457 - Manishearth:rollup, r=Manishearth

3391630

- Successful merges: #30272, #30286, #30365, #30381, #30384, #30398, #30406, #30408, #30420, #30431, #30447, #30452 - Failed merges:

tamird force-pushed the update-valgrind branch from b9689f4 to 3f054b3 Compare December 19, 2015 01:13

update valgrind suppressions

a3d81c6

tamird force-pushed the update-valgrind branch from c1e12e0 to a3d81c6 Compare December 25, 2015 20:50

nagisa mentioned this pull request Dec 31, 2015

Rollup of 4 pull requests #30660

Merged

bors added a commit that referenced this pull request Dec 31, 2015

Auto merge of #30660 - nagisa:rollup, r=steveklabnik

53cd573

- Successful merges: #30365, #30565, #30590, #30630 - Failed merges:

bors merged commit a3d81c6 into rust-lang:master Dec 31, 2015

tamird deleted the update-valgrind branch January 1, 2016 00:46

mk: actually run valgrind on x86_64-apple-darwin #30365

mk: actually run valgrind on x86_64-apple-darwin #30365

Conversation

tamird commented Dec 13, 2015

alexcrichton commented Dec 13, 2015

bors commented Dec 14, 2015

bors commented Dec 14, 2015

tamird commented Dec 14, 2015

pnkfelix commented Dec 14, 2015

tamird commented Dec 16, 2015

alexcrichton commented Dec 16, 2015

pnkfelix commented Dec 17, 2015

Manishearth commented Dec 18, 2015

tamird commented Dec 18, 2015

alexcrichton commented Dec 18, 2015

tamird commented Dec 18, 2015

alexcrichton commented Dec 18, 2015

tamird commented Dec 18, 2015

alexcrichton commented Dec 18, 2015

tamird commented Dec 19, 2015

alexcrichton commented Dec 19, 2015

tamird commented Dec 24, 2015

stdout:

stderr:

pnkfelix commented Dec 24, 2015

bors commented Dec 24, 2015

pnkfelix commented Dec 24, 2015

bors commented Dec 25, 2015

bors commented Dec 25, 2015

bors commented Dec 25, 2015

bors commented Dec 25, 2015

tamird commented Dec 25, 2015

tamird commented Dec 28, 2015

pnkfelix commented Dec 29, 2015

bors commented Dec 30, 2015

bors commented Dec 30, 2015

pnkfelix commented Dec 30, 2015

bors commented Dec 30, 2015

bors commented Dec 30, 2015

tamird commented Dec 30, 2015