Rollup of 12 pull requests #30457
Merged
Rollup of 12 pull requests #30457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
Dec 18, 2015
Manishearth
commented
- Successful merges: doc: improve Drain examples #30272, fix the error span when accessing tuple/struct fields in a constant #30286, mk: actually run valgrind on x86_64-apple-darwin #30365, Memchr in std #30381, Refactor error handling #30384, Fix typo #30398, change macro ambiguity example from ty to ident #30406, add tests for #26873 #30408, libsyntax: Merge OwnedSlice into ptr::P #30420, Trivial cleanup #30431, Clarified shadowing example #30447, Fix emitting asm and object file output at the same time #30452
- Failed merges:
The previous example had no chance of compiling in either form, due to the restrictive follow set for `ty`. This one has the desired behavior: http://is.gd/kYdw4g (well, I don't exactly desire this behavior at all, but it's true at least :p )
Also split out emitters into their own module.
The intention here is that Session is a very thin wrapper over the error handling infra.
Remove a needless variable and simply a cfg().
Added some additional descriptive sentences and changed x to an int in the example
LLVM doesn't really support reusing the same module to emit more than one file. One bug this causes is that the IR is invalidated by the stack coloring pass when emitting the first file, and then the IR verifier complains by the time we try to emit the second file. Also, we get different binaries with --emit=asm,link than with just --emit=link. In some cases leading to segfaults. Unfortunately, it seems that at this point in time, the most sensible option to circumvent this problem is to just clone the whole llvm module for the asm output if we need both, asm and obj file output. Fixes rust-lang#24876 Fixes rust-lang#26235
|
@bors r+ p=20 force |
|
📌 Commit aad3977 has been approved by |
|
⌛ Testing commit aad3977 with merge ce719cc... |
|
💔 Test failed - auto-win-msvc-64-opt |
…sakis previously the error was erased and a `non-const path` error was emitted at the location of the field access instead of at the overflow location (as can be seen in the playground: http://is.gd/EuAF5F )
|
@bors r+ force |
|
📌 Commit b8d0221 has been approved by |
|
⌛ Testing commit b8d0221 with merge d30272a... |
|
💔 Test failed - auto-mac-64-opt |
Should make it possible to add JSON or HTML errors. Also tidies up a lot.
…sanxiyn This fixes a double word typo, 'the'.
The previous example had no chance of compiling in either form, due to the restrictive follow set for `ty`. This one has the desired behavior: http://is.gd/kYdw4g (well, I don't exactly desire this behavior at all, but it's true at least :p )
|
@bors r+ force |
|
📌 Commit e4719b1 has been approved by |
|
⌛ Testing commit e4719b1 with merge a7d5b0c... |
|
💔 Test failed - auto-linux-musl-64-opt |
Part of rust-lang#30095 not causing mysterious segfaults. r? @nrc
Remove a needless variable and simply a cfg().
Added sentences for description of code and changed x in the example to an int
LLVM doesn't really support reusing the same module to emit more than one file. One bug this causes is that the IR is invalidated by the stack coloring pass when emitting the first file, and then the IR verifier complains by the time we try to emit the second file. Also, we get different binaries with --emit=asm,link than with just --emit=link. In some cases leading to segfaults. Unfortunately, it seems that at this point in time, the most sensible option to circumvent this problem is to just clone the whole llvm module for the asm output if we need both, asm and obj file output. Fixes rust-lang#24876 Fixes rust-lang#26235
|
@bors r+ |
|
📌 Commit a8e4246 has been approved by |
This was referenced Dec 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.