Fix def paths creation for items inlined from external crates. #30528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid duplicating the last element of the def path which led to paths like "std::slice::into_vec::into_vec".
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
/me ponders if there is a way to write a test for this |
|
@nikomatsakis IIRC we already have some run-make tests peeking at the symbol list of a crate. |
|
so the code looks fine, r=me, my only hesitation would be whether we can test this for the future. |
|
Def paths will show up in the upcoming codegen unit partitioning tests (that's how I became aware of the problem in the first place) so this will be tested once those land. |
|
@bors r+ |
|
📌 Commit 4c4195f has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Dec 25, 2015
…hs, r=nikomatsakis Avoid duplicating the last element of the def path which led to paths like "std::slice::into_vec::into_vec". cc @rust-lang/compiler
bors
added a commit
that referenced
this pull request
Dec 25, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid duplicating the last element of the def path which led to paths like "std::slice::into_vec::into_vec".
cc @rust-lang/compiler