Properly convert and translate unit structs into MIR #30551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struct Droppable;
fn mir() {
Droppable
}results in
|
|
LGTM! @bors: r+ |
|
📌 Commit 75e8f4a has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Dec 25, 2015
Fixes rust-lang#30514 i also went ahead and removed the redundant `ItemKind`s. r? @nikomatsakis (this is an easy one I guess)
bors
added a commit
that referenced
this pull request
Dec 25, 2015
| ty::TyBareFn(..) => (def_id, ItemKind::Function), | ||
| // This is a special case: a unit struct which is used as a value. We return a | ||
| // completely different ExprKind here to account for this special case. | ||
| ty::TyStruct(adt_def, substs) => return ExprKind::Adt { |
There was a problem hiding this comment.
can't you have the same problem with unit variants (e.g. Option::None)?
There was a problem hiding this comment.
Wow, I now feel kinda stupid not having noticed it myself 😃.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30514
i also went ahead and removed the redundant
ItemKinds.r? @nikomatsakis (this is an easy one I guess)