-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use a newtype for the variant discriminant in trans instead of u64 #30931
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
☔ The latest upstream changes (presumably #30890) made this pull request unmergeable. Please resolve the merge conflicts. |
fd23740
to
109dfe7
Compare
rebased |
at least some of the travis failure error messages seems related to this PR? |
109dfe7
to
6fef118
Compare
sorry about that. This time |
@bors r+ |
📌 Commit 6fef118 has been approved by |
it makes no sense here, accidentally introduced in rust-lang#30931
This is groundwork for #30587 (typestrong constant integrals), but imo it's a change that in itself is good, too, since we don't just juggle
u64
s around anymore.ty::Disr
will be changed to aConstInt
in #30587