Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert using trans::Disr in LoadRangeAssert #30996

Merged
merged 1 commit into from
Jan 18, 2016

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 18, 2016

it makes no sense here, accidentally introduced in #30931

r? @dotdash

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dotdash (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nagisa
Copy link
Member

nagisa commented Jan 18, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 18, 2016

📌 Commit 5081d4c has been approved by nagisa

@bors
Copy link
Collaborator

bors commented Jan 18, 2016

⌛ Testing commit 5081d4c with merge 84790fe...

@oli-obk oli-obk force-pushed the fix/load_range_assert branch from 5081d4c to d5f790c Compare January 18, 2016 10:22
@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 18, 2016

I forgot to remove a use, this will fail, it should be aborted.

@nagisa
Copy link
Member

nagisa commented Jan 18, 2016

@bors r-

@nagisa
Copy link
Member

nagisa commented Jan 18, 2016

@bors r+ retry force

@bors
Copy link
Collaborator

bors commented Jan 18, 2016

📌 Commit d5f790c has been approved by nagisa

@bors
Copy link
Collaborator

bors commented Jan 18, 2016

⌛ Testing commit d5f790c with merge d237506...

it makes no sense here, accidentally introduced in rust-lang#30931
@oli-obk oli-obk force-pushed the fix/load_range_assert branch from d5f790c to c02ba16 Compare January 18, 2016 10:31
@nagisa
Copy link
Member

nagisa commented Jan 18, 2016

@bors r+ c02ba16 retry force

bors added a commit that referenced this pull request Jan 18, 2016
it makes no sense here, accidentally introduced in #30931

r? @dotdash
@bors
Copy link
Collaborator

bors commented Jan 18, 2016

⌛ Testing commit c02ba16 with merge 50a8333...

@bors bors merged commit c02ba16 into rust-lang:master Jan 18, 2016
@oli-obk oli-obk deleted the fix/load_range_assert branch January 19, 2016 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants