Skip to content

Fix a minor issue in release note of 1.6 #31138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix a minor issue in release note of 1.6 #31138

wants to merge 1 commit into from

Conversation

upsuper
Copy link
Contributor

@upsuper upsuper commented Jan 23, 2016

[something] (renamed from something) would be recognized as a link to "renamed from something" instead of a link with a note after. Use [something][] to solve this issue.

`[something] (renamed from something)` would be recognized as a link to "renamed from something" instead of a link with a note after. Use `[something][]` to solve this issue.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Contributor

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@alexcrichton
Copy link
Member

Thanks for the PR! We currently don't normally take PRs against the stable branch of Rust directly, but rather all PRs are sent against the master branch and then we backport as necessary. Could you retarget this patch at the master branch and resubmit the PR?

@upsuper
Copy link
Contributor Author

upsuper commented Jan 23, 2016

Hmmm, but the RELEASES.md file on the master branch doesn't even have 1.6.0.

@alexcrichton
Copy link
Member

Oh I think they may be getting added in #31099, maybe a comment there instead perhaps?

@upsuper
Copy link
Contributor Author

upsuper commented Jan 23, 2016

This issue has been fixed in #31099 via the same method. You can consider this as a backport of the fix, then :)

@alexcrichton
Copy link
Member

We currently also don't backport to stable but rather just to beta, but we'll go through the normal backport process once it lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants