-
Notifications
You must be signed in to change notification settings - Fork 13.3k
book: Change "Failures" to "Errors" in doc special sections chapter #31345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
book: Change "Failures" to "Errors" in doc special sections chapter #31345
Conversation
This matches the usage in the standard library's documentation.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Hmmm, I would like to hear what @rust-lang/libs has to say about this. "Failures" is the term we agreed upon when we changed However, we may want to change that convention to |
Eep, I certainly wasn't expecting to be reporting a doc bug for the entire stdlib! |
I think the book should be consistent with |
I think |
Great, let's do it! @kamalmarhubi would you like to also double-check |
:-) |
And just in case:
|
What about just "failure" without the s? On Feb 1, 2016, 21:23 -0500, Kamal Marhubinotifications@github.com, wrote:
|
Urg, a bunch in |
There you go! |
@bors: r+ rollup thanks so much! |
📌 Commit 129a623 has been approved by |
…ion-errors, r=steveklabnik This matches the usage in the standard library's documentation.
This matches the usage in the standard library's documentation.