Safety docs about process::Child going out of scope #31327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no `Drop` implemented for `Child`, so if it goes out of scope in Rust-land and gets deallocated, the child process will continue to exist and execute. If users want a guarantee that the process has finished running and exited they must manually use `kill`, `wait`, or `wait_with_output`. Fixes rust-lang#31289.
| @@ -47,6 +47,14 @@ use thread::{self, JoinHandle}; | |||
| /// | |||
| /// assert!(ecode.success()); | |||
| /// ``` | |||
| /// | |||
| /// # Safety | |||
There was a problem hiding this comment.
AFAIK the "Safety" heading is for memory safety and memory safety only. Also AFAIK a child process terminating later than expected is not a memory safety hazard. If I'm correct about both things, this heading should be renamed.
There was a problem hiding this comment.
@rkruppe: Was wondering about that myself. Any suggestions?
There was a problem hiding this comment.
# Note is usually used for this kind of thing I believe.
dirk
force-pushed
the
dirk/process-child-safety-docs
branch
from
6c730da
to
7683922
Compare
|
re-queueing travis. The structure and format look right to me, but r? @alexcrichton because I don't know enough about the accuracy here. |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Feb 1, 2016
…, r=alexcrichton `Drop` is not implemented for `Child`, so if it goes out of scope in Rust-land and gets deallocated the child process will continue to exist and execute. If users want a guarantee that the process has finished running and exited they must manually use `kill`, `wait`, or `wait_with_output`. Fixes rust-lang#31289. r? @steveklabnik
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Feb 2, 2016
…, r=alexcrichton `Drop` is not implemented for `Child`, so if it goes out of scope in Rust-land and gets deallocated the child process will continue to exist and execute. If users want a guarantee that the process has finished running and exited they must manually use `kill`, `wait`, or `wait_with_output`. Fixes rust-lang#31289. r? @steveklabnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropis not implemented forChild, so if it goes out of scope in Rust-land and gets deallocated the child process will continue to exist and execute. If users want a guarantee that the process has finished running and exited they must manually usekill,wait, orwait_with_output.Fixes #31289.
r? @steveklabnik