Rollup of 11 pull requests #31350
Closed
Rollup of 11 pull requests #31350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doc part of rust-lang#30459
E0507 can occur when you try to move out of a member of a mutably borrowed struct, in which case `mem::replace` can help. Mentioning that here hopefully saves future users a trip to Google.
update tests emitter.rs
There is no `Drop` implemented for `Child`, so if it goes out of scope in Rust-land and gets deallocated, the child process will continue to exist and execute. If users want a guarantee that the process has finished running and exited they must manually use `kill`, `wait`, or `wait_with_output`. Fixes rust-lang#31289.
Spelling mistake - `familliar` > `familiar`
Some other shufflings as well: * Three powerpc triples for Linux have been added recently * An armv7 linux triple was added recently * The 64-bit Solaris triple is now mentioned in tier 3 We are currently now also building nightlies for iOS, powerpc triples, and armv7, but there hasn't been much vetting of the triples themselves so I've left them in tier 3 for now.
Updated documentation to clarify the difference between `and_then` and `map`. This also explains why we need `and_then` in addition to `map`. Please look at the diff for more information. r? @alexcrichton
Fixes rust-lang#30459 Fun fact: i wanted to write "Arabic" and "Hebrew" in Arabic and Hebrew, but vim kept doing the copy/paste in the wrong direction.
E0507 can occur when you try to move out of a member of a mutably borrowed struct, in which case `mem::replace` can help. Mentioning that here hopefully saves future users a trip to Google.
…, r=alexcrichton `Drop` is not implemented for `Child`, so if it goes out of scope in Rust-land and gets deallocated the child process will continue to exist and execute. If users want a guarantee that the process has finished running and exited they must manually use `kill`, `wait`, or `wait_with_output`. Fixes rust-lang#31289. r? @steveklabnik
Spelling mistake - `familliar` > `familiar`
Fixes rust-lang#31334 This is just a quicker fix for this issue; since I'm working on the next draft of the book, I don't want to put a huuuge amount of work into improving it here.
Space character is missed after `let some_usize`
…klabnik Some other shufflings as well: * Three powerpc triples for Linux have been added recently * An armv7 linux triple was added recently * The 64-bit Solaris triple is now mentioned in tier 3 We are currently now also building nightlies for iOS, powerpc triples, and armv7, but there hasn't been much vetting of the triples themselves so I've left them in tier 3 for now.
|
@bors: r+ p=1 |
|
📌 Commit 814f254 has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit 814f254 with merge 6d24534... |
|
💔 Test failed - auto-mac-64-opt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapandand_thenwith an example. #30971, Document LTR vs RTL wrt trim_* #31202, doc: bindings not needed for this example #31247, Improve message for rustc --explain E0507 #31270, fix overflow due to multiline error span #31281, Safety docs about process::Child going out of scope #31327, Fix typo in doc/book/getting-started.md #31340, Comment fix #31342, make this example more obvious #31344, Fix a documentation typo #31346, doc: Move 32-bit MSVC to a tier 1 platform #31348