Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve: don't compute LastPrivate data for Def::Err to avoid ICE #31716

Merged
merged 2 commits into from
Feb 19, 2016
Merged

Resolve: don't compute LastPrivate data for Def::Err to avoid ICE #31716

merged 2 commits into from
Feb 19, 2016

Conversation

jseyfried
Copy link
Contributor

Fixes #31714

@alexcrichton
Copy link
Member

r? @nrc (more familiar with this since I last touched it)

@rust-highfive rust-highfive assigned nrc and unassigned alexcrichton Feb 16, 2016
@jseyfried
Copy link
Contributor Author

Fixes #31729

nrc
nrc reviewed Feb 19, 2016
View reviewed changes
src/test/compile-fail/import.rs
}

fn main() {
zed::foo(); // Check that this does not panic. Ideally, it would be a privacy error.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you file an issue for this please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah; in fact, I can fix it now

@nrc
Copy link
Member

nrc commented Feb 19, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 19, 2016

📌 Commit 1b5d2f2 has been approved by nrc

@jseyfried
Copy link
Contributor Author

@nrc The above commit addresses your comment by making the error for trying to use an inaccessible unresolved import the same as if it the import were resolved.

@jseyfried
Copy link
Contributor Author

Right now, this error is just "unresolved name" -- it's not a privacy error since we can't use non-pub imports in non-lexical scopes (see #13598).
This could be improved to a more descriptive error -- I can file an issue for that.

@nrc
Copy link
Member

nrc commented Feb 19, 2016

Thanks!

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 19, 2016

📌 Commit 08b9097 has been approved by nrc

bors added a commit that referenced this pull request Feb 19, 2016
@bors
Auto merge of #31716 - jseyfried:fix_privacy_for_def_err, r=nrc
917db28 
Fixes #31714
@bors
Copy link
Contributor

bors commented Feb 19, 2016

⌛ Testing commit 08b9097 with merge 917db28...

@bors
Copy link
Contributor

bors commented Feb 19, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 08b9097 into rust-lang:master Feb 19, 2016
This was referenced Feb 19, 2016
Merged
Merged
@jseyfried jseyfried deleted the fix_privacy_for_def_err branch March 25, 2016 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jseyfried @alexcrichton @nrc @bors