Batch up all plugin breaking changes #32767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jroesch (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=100 force |
|
📌 Commit 0b24c5d has been approved by |
|
⌛ Testing commit 0b24c5d with merge faca0e2... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
|
@bors retry |
|
@bors retry force |
|
@bors force |
|
⌛ Testing commit 0b24c5d with merge c91993d... |
|
💔 Test failed - auto-linux-musl-64-opt |
The AST part of rust-lang#31937 Unlike HIR, AST still uses `Option` for field names because parser can't know field indexes reliably due to constructions like ``` struct S(#[cfg(false)] u8, u8); // The index of the second field changes from 1 during parsing to 0 after expansion. ``` and I wouldn't like to put the burden of renaming fields on expansion passes and syntax extensions. plugin-[breaking-change] cc rust-lang#31645 r? @Manishearth
r? @nikomatsakis Conflicts: src/librustc_save_analysis/lib.rs src/libsyntax/ast_util.rs
Manishearth
force-pushed
the
breakingbatch
branch
from
0b24c5d
to
552af51
Compare
|
@bors r+ |
|
📌 Commit 552af51 has been approved by |
|
@bors force |
|
💔 Test failed - auto-mac-32-opt |
|
Huh, that doesn't make any sense, tidy passes everywhere else. |
|
@bors retry |
|
@bors force |
This was referenced Apr 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32688 already landed so we should get this into the same nightly.
cc #31645