rustdoc: refine cross-crate impl inlining #33002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The thread-local isn't needed and consists of mostly empty fields which were just used to move the data into `html::render::CACHE_KEY`.
mitaa
force-pushed
the
rdoc-cross-impls
branch
2 times, most recently
from
78f29ce
to
9589d72
Compare
| use ::visit_lib::LibEmbargoVisitor; | ||
| // FIXME: this is only partially correct for local items | ||
| // (we're reusing the access levels from crateanalysis, | ||
| // which does not considering `doc(hidden)`ness) |
There was a problem hiding this comment.
After thinking more about this, this probably doesn't matter since an impl in an external crate can't reference a local type or trait (right??).
This changes the current rule that impls within `doc(hidden)` modules aren't inlined, to only inlining impls where the implemented trait and type are reachable in documentation.
|
Hmm, this probably doesn't yet fix this since this isn't related to inlining. #![crate_type="lib"]
pub trait Bar {}
#[doc(hidden)]
pub mod hidden {
pub struct Foo;
}
// impl shown in `foo::Bar`s implementors section (but without link)
impl Bar for hidden::Foo {}edit: filed as #33069 |
bors
added a commit
that referenced
this pull request
Apr 19, 2016
rustdoc: refine cross-crate impl inlining This changes the current rule that impls within `doc(hidden)` modules aren't inlined, to only inlining impls where the implemented trait and type are reachable in documentation. fixes #14586 fixes #31948 .. and also applies the reachability checking to cross-crate links. fixes #28480 r? @alexcrichton
This was referenced Apr 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the current rule that impls within
doc(hidden)modules aren't inlined, to only inlining impls where the implemented trait and type are reachable in documentation.fixes #14586
fixes #31948
.. and also applies the reachability checking to cross-crate links.
fixes #28480
r? @alexcrichton