Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn unused trait imports, rebased #33091

Merged
merged 7 commits into from
May 8, 2016

Conversation

sanxiyn
Copy link
Member

@sanxiyn sanxiyn commented Apr 19, 2016

Rebase of #30021.

Fix #25730.

@rust-highfive
Copy link
Collaborator

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Contributor

bors commented Apr 19, 2016

☔ The latest upstream changes (presumably #33002) made this pull request unmergeable. Please resolve the merge conflicts.

@nrc
Copy link
Member

nrc commented Apr 20, 2016

r+ with a rebase

@sanxiyn
Copy link
Member Author

sanxiyn commented Apr 20, 2016

Travis failure is legit.

f64::sqrt is defined in std. Since librand is no_std, librand defines its own version in FloatMath trait and imports it. But randtest is not no_std, so FloatMath import is necessary for librand and unused for randtest.

@sanxiyn
Copy link
Member Author

sanxiyn commented Apr 20, 2016

Rebased and fixed tests.

@nrc
Copy link
Member

nrc commented Apr 20, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 20, 2016

📌 Commit baf2fff has been approved by nrc

@bors
Copy link
Contributor

bors commented Apr 21, 2016

⌛ Testing commit baf2fff with merge 2209876...

@bors
Copy link
Contributor

bors commented Apr 21, 2016

💔 Test failed - auto-win-msvc-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Apr 21, 2016 at 11:01 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-msvc-64-opt
http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/3888


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#33091 (comment)

@bors
Copy link
Contributor

bors commented Apr 22, 2016

⌛ Testing commit baf2fff with merge c148426...

@bors
Copy link
Contributor

bors commented Apr 22, 2016

💔 Test failed - auto-win-msvc-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Fri, Apr 22, 2016 at 8:23 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-msvc-64-opt
http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/3899


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33091 (comment)

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 22, 2016
@mitaa
Copy link
Contributor

mitaa commented Apr 23, 2016

cc #33154

I assume this has something to do with this PR?

C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libstd\sys/windows\fs.rs:12:5: 12:20 error: unused import
C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libstd\sys/windows\fs.rs:12 use io::prelude::*;
                                                                                     ^~~~~~~~~~~~~~~
C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libstd\lib.rs:283:31: 283:39 note: lint level defined here
C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libstd\lib.rs:283 #![cfg_attr(not(stage0), deny(warnings))]
                                                                                                     ^~~~~~~~

@sanxiyn
Copy link
Member Author

sanxiyn commented Apr 23, 2016

Yes, it does. Thanks for noticing.

@sanxiyn
Copy link
Member Author

sanxiyn commented Apr 23, 2016

@bors r-

@sanxiyn
Copy link
Member Author

sanxiyn commented Apr 25, 2016

@bors r=nrc

@bors
Copy link
Contributor

bors commented Apr 25, 2016

📌 Commit 71f19ba has been approved by nrc

@bors
Copy link
Contributor

bors commented Apr 25, 2016

⌛ Testing commit 71f19ba with merge 2bb7770...

@bors
Copy link
Contributor

bors commented Apr 25, 2016

💔 Test failed - auto-linux-64-cargotest

@bluss
Copy link
Member

bluss commented Apr 25, 2016

Cargo should not be using deny since that makes it explicitly not forward compatible with lint changes.

@brson can we change cargotest to cap the lint level?

@sanxiyn
Copy link
Member Author

sanxiyn commented Apr 25, 2016

We could use RUSTFLAGS. Two problems: first, cargo used by rustbuild at the moment is too old and does not support RUSTFLAGS. Second, setting RUSTFLAGS interferes with running cargo test suite.

@bors
Copy link
Contributor

bors commented May 6, 2016

⌛ Testing commit 282afda with merge 4bb89bd...

@bors
Copy link
Contributor

bors commented May 6, 2016

💔 Test failed - auto-linux-64-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Fri, May 6, 2016 at 6:07 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-64-opt-rustbuild
http://buildbot.rust-lang.org/builders/auto-linux-64-opt-rustbuild/builds/997


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33091 (comment)

@bors
Copy link
Contributor

bors commented May 6, 2016

⌛ Testing commit 282afda with merge 2843f13...

@bors
Copy link
Contributor

bors commented May 6, 2016

💔 Test failed - auto-linux-64-opt-rustbuild

@sanxiyn
Copy link
Member Author

sanxiyn commented May 7, 2016

@bors retry

@bors
Copy link
Contributor

bors commented May 7, 2016

⌛ Testing commit 282afda with merge 464f387...

@bors
Copy link
Contributor

bors commented May 7, 2016

💔 Test failed - auto-linux-64-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Sat, May 7, 2016 at 7:59 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-64-opt-rustbuild
http://buildbot.rust-lang.org/builders/auto-linux-64-opt-rustbuild/builds/1015


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33091 (comment)

@bors
Copy link
Contributor

bors commented May 7, 2016

⌛ Testing commit 282afda with merge a98ad9f...

@bors
Copy link
Contributor

bors commented May 7, 2016

⛄ The build was interrupted to prioritize another pull request.

@bors
Copy link
Contributor

bors commented May 8, 2016

⌛ Testing commit 282afda with merge b4a9f6b...

@bors
Copy link
Contributor

bors commented May 8, 2016

💔 Test failed - auto-linux-64-opt-rustbuild

@sanxiyn
Copy link
Member Author

sanxiyn commented May 8, 2016

@bors retry

@bors
Copy link
Contributor

bors commented May 8, 2016

⌛ Testing commit 282afda with merge 8e414e0...

bors added a commit that referenced this pull request May 8, 2016
Warn unused trait imports, rebased

Rebase of #30021.

Fix #25730.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants