-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn unused trait imports, rebased #33091
Conversation
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #33002) made this pull request unmergeable. Please resolve the merge conflicts. |
r+ with a rebase |
Travis failure is legit. f64::sqrt is defined in std. Since librand is no_std, librand defines its own version in FloatMath trait and imports it. But randtest is not no_std, so FloatMath import is necessary for librand and unused for randtest. |
0d38418
to
6ede0f8
Compare
Rebased and fixed tests. |
@bors: r+ |
📌 Commit baf2fff has been approved by |
⌛ Testing commit baf2fff with merge 2209876... |
💔 Test failed - auto-win-msvc-64-opt |
@bors: retry On Thu, Apr 21, 2016 at 11:01 AM, bors notifications@github.com wrote:
|
⌛ Testing commit baf2fff with merge c148426... |
💔 Test failed - auto-win-msvc-64-opt |
@bors: retry On Fri, Apr 22, 2016 at 8:23 AM, bors notifications@github.com wrote:
|
Warn unused trait imports, rebased Rebase of rust-lang#30021. Fix rust-lang#25730.
cc #33154 I assume this has something to do with this PR?
|
Yes, it does. Thanks for noticing. |
@bors r- |
@bors r=nrc |
📌 Commit 71f19ba has been approved by |
⌛ Testing commit 71f19ba with merge 2bb7770... |
💔 Test failed - auto-linux-64-cargotest |
Cargo should not be using deny since that makes it explicitly not forward compatible with lint changes. @brson can we change cargotest to cap the lint level? |
We could use RUSTFLAGS. Two problems: first, cargo used by rustbuild at the moment is too old and does not support RUSTFLAGS. Second, setting RUSTFLAGS interferes with running cargo test suite. |
⌛ Testing commit 282afda with merge 4bb89bd... |
💔 Test failed - auto-linux-64-opt-rustbuild |
@bors: retry On Fri, May 6, 2016 at 6:07 AM, bors notifications@github.com wrote:
|
⌛ Testing commit 282afda with merge 2843f13... |
💔 Test failed - auto-linux-64-opt-rustbuild |
@bors retry |
⌛ Testing commit 282afda with merge 464f387... |
💔 Test failed - auto-linux-64-opt-rustbuild |
@bors: retry On Sat, May 7, 2016 at 7:59 AM, bors notifications@github.com wrote:
|
⌛ Testing commit 282afda with merge a98ad9f... |
⛄ The build was interrupted to prioritize another pull request. |
⌛ Testing commit 282afda with merge b4a9f6b... |
💔 Test failed - auto-linux-64-opt-rustbuild |
@bors retry |
Rebase of #30021.
Fix #25730.