Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pretty printing to use the compiler API #33119

Merged
merged 5 commits into from
May 3, 2016
Merged

Conversation

nrc
Copy link
Member

@nrc nrc commented Apr 20, 2016

No description provided.

@rust-highfive
Copy link
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@nrc
Copy link
Member Author

nrc commented Apr 20, 2016

This is a [breaking-change] if you are using the compiler API (I guess that should be in a commit message).

@bors
Copy link
Collaborator

bors commented Apr 22, 2016

☔ The latest upstream changes (presumably #33089) made this pull request unmergeable. Please resolve the merge conflicts.

@nrc
Copy link
Member Author

nrc commented Apr 26, 2016

rebased

r? @pnkfelix

@rust-highfive rust-highfive assigned pnkfelix and unassigned arielb1 Apr 26, 2016
@bors
Copy link
Collaborator

bors commented May 2, 2016

☔ The latest upstream changes (presumably #33296) made this pull request unmergeable. Please resolve the merge conflicts.

@pnkfelix
Copy link
Member

pnkfelix commented May 2, 2016

@nrc r=me sorry I didn't get to it before it hit a new conflict

nrc added 5 commits May 3, 2016 10:48
This commit still does a lot of building in pretty because we always run after parsing.
Note that this whole PR is a [breaking-change] for clients of the Compiler API.
@nrc
Copy link
Member Author

nrc commented May 2, 2016

@bors: r=pnkfelix

@bors
Copy link
Collaborator

bors commented May 2, 2016

📌 Commit c1c6e99 has been approved by pnkfelix

@bors
Copy link
Collaborator

bors commented May 3, 2016

⌛ Testing commit c1c6e99 with merge 7d8100a...

bors added a commit that referenced this pull request May 3, 2016
Refactor pretty printing to use the compiler API
@bors bors merged commit c1c6e99 into rust-lang:master May 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants