rustdoc: add "src" links to individual impls #33382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Screenshots: |
|
I'll take a look to the CSS. |
|
I like it! Thanks! |
|
@bors: r+ rollup |
|
📌 Commit 7a0d317 has been approved by |
|
@bors: r- actually, i would like @alexcrichton to also check this out; it's a relatively big diff to the internals and he knows them better than I |
| impl_: i, | ||
| dox: attrs.value("doc").map(|s|s.to_owned()), | ||
| stability: item.stability.clone(), | ||
| // FIXME: would like to move the item here, but |
There was a problem hiding this comment.
How come the bindings above were switched to ref? Wouldn't that mean you can avoid the clone() here?
There was a problem hiding this comment.
Without the ref above, I can't even access item anymore since it's been partially moved; with the ref, I can't move it into the Impl because it's partially borrowed :)
|
Thanks! We've also had requests to jump to the source of a particular method itself from time to time, but only having it on impls for now seems like a nice balance between clutter and usability, so sounds like a good strategy to me. |
Since these impls can be scattered around quite a bit, it is nice to be able to jump to the location where individual methods and trait impls are defined. Fixes: rust-lang#30416
|
Pushed a new version with review comments addressed. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 7, 2016
rustdoc: add "src" links to individual impls Since these impls can be scattered around quite a bit, it is nice to be able to jump to the location where individual methods and trait impls are defined. NOTE: this needs an update to the CSS, which I'd like to leave for whoever is the "rustdoc frontend champion". The new [src] links are currently too large and bold. Also, the interaction with the "since version X" annotations is not good. Fixes: rust-lang#30416
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
May 7, 2016
rustdoc: add "src" links to individual impls Since these impls can be scattered around quite a bit, it is nice to be able to jump to the location where individual methods and trait impls are defined. NOTE: this needs an update to the CSS, which I'd like to leave for whoever is the "rustdoc frontend champion". The new [src] links are currently too large and bold. Also, the interaction with the "since version X" annotations is not good. Fixes: rust-lang#30416
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
May 7, 2016
rustdoc: add "src" links to individual impls Since these impls can be scattered around quite a bit, it is nice to be able to jump to the location where individual methods and trait impls are defined. NOTE: this needs an update to the CSS, which I'd like to leave for whoever is the "rustdoc frontend champion". The new [src] links are currently too large and bold. Also, the interaction with the "since version X" annotations is not good. Fixes: rust-lang#30416
bors
added a commit
that referenced
this pull request
May 7, 2016
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 9, 2016
…klabnik Update CSS for future rustdoc merge cc rust-lang#33382 r? @steveklabnik cc @Manishearth cc @birkenfeld
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 9, 2016
…klabnik Update CSS for future rustdoc merge cc rust-lang#33382 r? @steveklabnik cc @Manishearth cc @birkenfeld
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 9, 2016
…klabnik Update CSS for future rustdoc merge cc rust-lang#33382 r? @steveklabnik cc @Manishearth cc @birkenfeld
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these impls can be scattered around quite a bit, it is nice to be able to jump to the location where individual methods and trait impls are defined.
NOTE: this needs an update to the CSS, which I'd like to leave for whoever is the "rustdoc frontend champion". The new [src] links are currently too large and bold. Also, the interaction with the "since version X" annotations is not good.
Fixes: #30416