-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errors in the doc #33409
Merged
Merged
errors in the doc #33409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(rust_highfive has picked a reviewer for you, use r? to override) |
@@ -214,7 +214,7 @@ pub trait Iterator { | |||
/// Like most indexing operations, the count starts from zero, so `nth(0)` | |||
/// returns the first value, `nth(1)` the second, and so on. | |||
/// | |||
/// `nth()` will return `None` if `n` is larger than the length of the | |||
/// `nth()` will return `None` if `n` >= the length of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to stick with the words here, "is greater than or equal to the length"
Thanks for this! One small nit and then r=me |
Done. |
@bors: r+ rollup Thank you! |
📌 Commit 16219de has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
May 5, 2016
errors in the doc
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
May 5, 2016
errors in the doc
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
May 5, 2016
errors in the doc
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
May 6, 2016
errors in the doc
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 7, 2016
errors in the doc
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
May 7, 2016
errors in the doc
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
May 7, 2016
errors in the doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.