Preparatory refactorings for collector-driven trans. #33473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
cc @rust-lang/compiler |
| @@ -1191,7 +1191,7 @@ fn create_trans_items_for_default_impls<'a, 'tcx>(ccx: &CrateContext<'a, 'tcx>, | |||
| assert!(mth.is_provided); | |||
There was a problem hiding this comment.
this commit seems good
|
@michaelwoerister this seems pretty unobjectionable. r=me but some nits:
|
|
Great. Thanks for the quick review! |
|
@bors r=nikomatsakis |
|
📌 Commit b37d7a4 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 8, 2016
…, r=nikomatsakis Preparatory refactorings for collector-driven trans. This is a set of refactorings that allows to do translation item collection and partitioning before LocalCrateContext instances or LLVM modules are generated. As a consequence we can now create LocalCrateContexts already with knowledge of the codegen unit it will be used for. This is a preparation step for driving trans by the results of codegen unit partitioning.
bors
added a commit
that referenced
this pull request
May 8, 2016
bors
added a commit
that referenced
this pull request
May 8, 2016
|
⌛ Testing commit b37d7a4 with merge e2c69e3... |
|
💔 Test failed - auto-linux-64-cross-freebsd |
|
☔ The latest upstream changes (presumably #33478) made this pull request unmergeable. Please resolve the merge conflicts. |
michaelwoerister
force-pushed
the
split-cratecontext
branch
from
b37d7a4 to
30e19aa
Compare
|
@bors r=nikomatsakis rebased ... |
|
📌 Commit 30e19aa has been approved by |
|
(fails travis) |
…ext. Plus make it produce a nicer dependency graph via DepTrackingMap::memoize().
…efore creating LocalCrateContexts.
michaelwoerister
force-pushed
the
split-cratecontext
branch
from
30e19aa to
118cc9e
Compare
|
@bors r=nikomatsakis |
|
📌 Commit 118cc9e has been approved by |
bors
added a commit
that referenced
this pull request
May 10, 2016
…sakis Preparatory refactorings for collector-driven trans. This is a set of refactorings that allows to do translation item collection and partitioning before LocalCrateContext instances or LLVM modules are generated. As a consequence we can now create LocalCrateContexts already with knowledge of the codegen unit it will be used for. This is a preparation step for driving trans by the results of codegen unit partitioning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of refactorings that allows to do translation item collection and partitioning before LocalCrateContext instances or LLVM modules are generated. As a consequence we can now create LocalCrateContexts already with knowledge of the codegen unit it will be used for. This is a preparation step for driving trans by the results of codegen unit partitioning.