trans: callee: normalize trait_ref before use #33478
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
r? @eddyb Thanks for doing this 😄. As for the test, run-pass that compiles without ICE is enough. |
eddyb
added
the
beta-nominated
xen0n
force-pushed
the
normalize-callee-trait-ref
branch
from
7dce338 to
4f22878
Compare
xen0n
changed the title
Fixes rust-lang#33436 and rust-lang#33461. Test case is from rust-lang#33461.
xen0n
force-pushed
the
normalize-callee-trait-ref
branch
from
4f22878 to
dcdf761
Compare
|
@bors r+ |
|
📌 Commit dcdf761 has been approved by |
|
Added testcase and pushed. (Reason why the Travis CI status is gone: I made a mistake of allowing 2 blank lines after copyright header in the testcase, which I summarily fixed and re-pushed; however Travis is quick enough to create a build for the replaced commit, and haven't created one for the current commit. As the difference is only one blank line the outcome shouldn't matter, but sorry for the extra noise.) |
…=eddyb trans: callee: normalize trait_ref before use This fixes rust-lang#33436 and rust-lang#33461. Ran the tests and nothing else seems to be affected. P.S. How to write the regression test for this fix? Does this qualify as run-pass or run-make, as the test only needs to be successfully compiled to be considered passed? Will add the testcase (the minimal example in rust-lang#33461 seems fit) after clarifying this.
trans: callee: normalize trait_ref before use This fixes #33436 and #33461. Ran the tests and nothing else seems to be affected. P.S. How to write the regression test for this fix? Does this qualify as run-pass or run-make, as the test only needs to be successfully compiled to be considered passed? Will add the testcase (the minimal example in #33461 seems fit) after clarifying this.
|
cc @rust-lang/compiler |
|
approving for backport because this fixes a regression and is very simple |
nikomatsakis
added
the
beta-accepted
Backport #33478 to beta, bump version
alexcrichton
removed
the
beta-nominated
This fixes #33436 and #33461. Ran the tests and nothing else seems to be affected.
P.S. How to write the regression test for this fix? Does this qualify as run-pass or run-make, as the test only needs to be successfully compiled to be considered passed? Will add the testcase (the minimal example in #33461 seems fit) after clarifying this.