Skip to content

Add more details and examples in error codes #33584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2016
Merged

Add more details and examples in error codes #33584

merged 1 commit into from
May 15, 2016

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez changed the title Add more details and examples Add more details and examples in error codes May 12, 2016
@GuillaumeGomez GuillaumeGomez force-pushed the error_code_improvements branch from 5a37a2e to e4e4868 Compare May 12, 2016 12:42
@GuillaumeGomez GuillaumeGomez force-pushed the error_code_improvements branch from e4e4868 to 5f2099d Compare May 12, 2016 14:45
@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented May 14, 2016

📌 Commit 5f2099d has been approved by steveklabnik

@eddyb eddyb mentioned this pull request May 14, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request May 15, 2016
@Manishearth
Rollup merge of rust-lang#33584 - GuillaumeGomez:error_code_improveme…
65814df 
…nts, r=steveklabnik

Add more details and examples in error codes

r? @steveklabnik
@Manishearth Manishearth mentioned this pull request May 15, 2016
Merged
bors added a commit that referenced this pull request May 15, 2016
@bors
Auto merge of #33658 - Manishearth:rollup, r=Manishearth
9f58fb7 
Rollup of 14 pull requests

- Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33584, #33585, #33590, #33591, #33598
- Failed merges: #33578
@bors bors merged commit 5f2099d into rust-lang:master May 15, 2016
@GuillaumeGomez GuillaumeGomez deleted the error_code_improvements branch May 15, 2016 22:29
bors added a commit that referenced this pull request May 16, 2016
@bors
Auto merge of #33643 - eddyb:rollup, r=eddyb
bb39c49 
Rollup of 27 pull requests

- Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33584, #33585, #33588, #33590, #33591, #33593, #33598, #33600, #33602, #33603, #33604, #33605, #33607, #33612, #33620, #33633, #33634, #33635
- Failed merges: #33578
Ms2ger
Ms2ger reviewed May 16, 2016
View reviewed changes
src/librustc_typeck/diagnostics.rs
@@ -45,8 +45,8 @@ Matching with the wrong number of fields has no sensible interpretation:

```compile_fail
enum Fruit {
Apple(String, String),
Pear(u32),
Fruit::Apple(String, String),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @steveklabnik @bors @Ms2ger