Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error description for E0455 #33393

Merged
merged 1 commit into from
May 15, 2016
Merged

Add error description for E0455 #33393

merged 1 commit into from
May 15, 2016

Conversation

cristianoliveira
Copy link
Contributor

r? @GuillaumeGomez.

About this error there is no much thing to explain. The short description says enough to understand. Feel free to review.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

birkenfeld
birkenfeld reviewed May 4, 2016
View reviewed changes
src/librustc_metadata/diagnostics.rs
@@ -26,6 +26,16 @@ name. Example:
```
"##,

E0455: r##"
A framework kind link was used and the OS utilized to compile isn't the OSX. Erroneous code example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the running OS really have to be OSX, or just the target we're compiling for?

Copy link
Member

@GuillaumeGomez GuillaumeGomez May 4, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to compile it on OSX and use it on OSX as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and the sentence sounds strange here as well. Did you mean "A framework link kind..."?

@cristianoliveira
Copy link
Contributor Author

#32777

GuillaumeGomez
GuillaumeGomez reviewed May 4, 2016
View reviewed changes
src/librustc_metadata/diagnostics.rs
// OS used to compile is Linux for example
```

When using 'framework' link kind ensure to utilize OSX to compile the code.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"When using 'framework' link kind, please ensure to use OSX to compile the code."

@GuillaumeGomez
Copy link
Member

Two last nits, sqaush commits and we're good to merge!

@cristianoliveira
Copy link
Contributor Author

Done.

@GuillaumeGomez
Copy link
Member

Thanks for your work!

r=me @steveklabnik @Manishearth

@cristianoliveira
Copy link
Contributor Author

:)

Manishearth
Manishearth reviewed May 5, 2016
View reviewed changes
src/librustc_metadata/diagnostics.rs
@@ -26,6 +26,18 @@ name. Example:
```
"##,

E0455: r##"
A framework link kind was used and the OS used to compile isn't the OSX.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"isn't OS X"

Mention that link kinds are only allowed on OS X.

@cristianoliveira
Copy link
Contributor Author

Done.

@GuillaumeGomez
Copy link
Member

Thanks!

r=me

steveklabnik
steveklabnik reviewed May 10, 2016
View reviewed changes
src/librustc_metadata/diagnostics.rs
E0455: r##"
A framework link kind was used and the OS used to compile isn't the OS X
cause native frameworks are only available on OS X targets.
Erroneous code example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a newline above this, to make it its own paragraph

@steveklabnik
Copy link
Member

Thanks @cristianoliveira ! I do have some grammar nits before we can merge this in.

@cristianoliveira
Copy link
Contributor Author

Great! I will change it. :)

@cristianoliveira
Add error description for E0455
85e0242 
- Adding name attribute to the sample code - Fix description sentences
@cristianoliveira
Copy link
Contributor Author

Done.

Also, thank you guys for being patient with the grammar issues. ^^
You are great!

@GuillaumeGomez
Copy link
Member

Thanks to you for your contribution. :)

Seems all good for me @steveklabnik.

@steveklabnik
Copy link
Member

@cristianoliveira thanks for being patient yourself! It can be tough to go through like 5 rounds of grammar review 😄

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 12, 2016

📌 Commit 85e0242 has been approved by steveklabnik

eddyb added a commit to eddyb/rust that referenced this pull request May 12, 2016
@eddyb
Rollup merge of rust-lang#33393 - cristianoliveira:docs-error-explana…
51e7bd3 
…tion, r=steveklabnik

Add error description for E0455

r? @GuillaumeGomez.

About this error there is no much thing to explain. The short description says enough to understand. Feel free to review.
@eddyb eddyb mentioned this pull request May 12, 2016
Closed
bors added a commit that referenced this pull request May 12, 2016
@bors
Auto merge of #33597 - eddyb:rollup, r=eddyb
2c5ce8c 
Rollup of 23 pull requests

- Successful merges: #33282, #33342, #33393, #33450, #33513, #33517, #33531, #33532, #33533, #33534, #33538, #33541, #33544, #33552, #33555, #33560, #33563, #33565, #33566, #33572, #33580, #33590, #33596
- Failed merges: #33578
@cristianoliveira
Copy link
Contributor Author

:D

@eddyb eddyb mentioned this pull request May 13, 2016
Closed
eddyb added a commit to eddyb/rust that referenced this pull request May 13, 2016
@eddyb
Rollup merge of rust-lang#33393 - cristianoliveira:docs-error-explana…
be92e9b 
…tion, r=steveklabnik

Add error description for E0455

r? @GuillaumeGomez.

About this error there is no much thing to explain. The short description says enough to understand. Feel free to review.
sanxiyn added a commit to sanxiyn/rust that referenced this pull request May 14, 2016
@sanxiyn
Rollup merge of rust-lang#33393 - cristianoliveira:docs-error-explana…
9c50746 
…tion, r=steveklabnik

Add error description for E0455

r? @GuillaumeGomez.

About this error there is no much thing to explain. The short description says enough to understand. Feel free to review.
@sanxiyn sanxiyn mentioned this pull request May 14, 2016
Closed
bors added a commit that referenced this pull request May 14, 2016
@bors
Auto merge of #33629 - sanxiyn:rollup, r=sanxiyn
a9d15db 
Rollup of 15 pull requests

- Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33590, #33591, #33598, #33603, #33604, #33605
- Failed merges: #33578
@eddyb eddyb mentioned this pull request May 14, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request May 15, 2016
@Manishearth
Rollup merge of rust-lang#33393 - cristianoliveira:docs-error-explana…
03ec483 
…tion, r=steveklabnik

Add error description for E0455

r? @GuillaumeGomez.

About this error there is no much thing to explain. The short description says enough to understand. Feel free to review.
@Manishearth Manishearth mentioned this pull request May 15, 2016
Merged
bors added a commit that referenced this pull request May 15, 2016
@bors
Auto merge of #33658 - Manishearth:rollup, r=Manishearth
9f58fb7 
Rollup of 14 pull requests

- Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33584, #33585, #33590, #33591, #33598
- Failed merges: #33578
@bors bors merged commit 85e0242 into rust-lang:master May 15, 2016
bors added a commit that referenced this pull request May 16, 2016
@bors
Auto merge of #33643 - eddyb:rollup, r=eddyb
bb39c49 
Rollup of 27 pull requests

- Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33584, #33585, #33588, #33590, #33591, #33593, #33598, #33600, #33602, #33603, #33604, #33605, #33607, #33612, #33620, #33633, #33634, #33635
- Failed merges: #33578
@cristianoliveira cristianoliveira deleted the docs-error-explanation branch May 27, 2016 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cristianoliveira @rust-highfive @GuillaumeGomez @steveklabnik @bors @birkenfeld @nikomatsakis @Manishearth