rustbuild: Add support for crate tests + doctests #33282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson |
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
48 tasks
| cargo.args(&build.flags.args); | ||
|
|
||
| build.run(&mut cargo); | ||
| } |
There was a problem hiding this comment.
This is fairly ugly function. Why search the dag like this and run cargo with a bunch of -p flags instead of calling cargo test on every individual crate?
There was a problem hiding this comment.
Running cargo test with a bunch of -p flags gives us the ability to compile all the crate tests in parallel (but run them sequentially). Ideally this'd just be cargo test --all, but unfortunately that's not implemented yet :(
Running cargo test on each individual crate would work, but we'd still have to discover the list of crates somewhere and we unfortunately wouldn't get the same parallelism :(
|
@bors r+ |
|
📌 Commit 58902f5 has been approved by |
|
⌛ Testing commit 58902f5 with merge b0e3f7a... |
|
💔 Test failed - auto-win-msvc-64-cargotest |
alexcrichton
force-pushed
the
rustbuild-crate-tests
branch
from
58902f5
to
4c42905
Compare
|
@bors: r=brson 4c42905 |
|
⌛ Testing commit 4c42905 with merge 4f41647... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
alexcrichton
force-pushed
the
rustbuild-crate-tests
branch
from
4c42905
to
7606bfd
Compare
|
@bors: r=brson 7606bfd |
|
⌛ Testing commit 7606bfd with merge 58a22a2... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
alexcrichton
force-pushed
the
rustbuild-crate-tests
branch
from
7606bfd
to
f5a73cb
Compare
|
@bors: r=brson f5a73cb Chalking up another segfault to opt-level=3 ... |
|
⌛ Testing commit f5a73cb with merge de696cd... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
Ensure that `rerun-if-changed` is printed for all build scripts to ensure that they've all got the right list of dependencies.
alexcrichton
force-pushed
the
rustbuild-crate-tests
branch
from
f5a73cb
to
afbcf90
Compare
alexcrichton
force-pushed
the
rustbuild-crate-tests
branch
from
882e878
to
d11e3c1
Compare
|
@bors: r=brson d11e3c1 |
|
⌛ Testing commit d11e3c1 with merge 4d9c301... |
|
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
This commit adds support to rustbuild to run crate unit tests (those defined by `#[test]`) as well as documentation tests. All tests are powered by `cargo test` under the hood. Each step requires the `libtest` library is built for that corresponding stage. Ideally the `test` crate would be a dev-dependency, but for now it's just easier to ensure that we sequence everything in the right order. Currently no filtering is implemented, so there's not actually a method of testing *only* libstd or *only* libcore, but rather entire swaths of crates are tested all at once. A few points of note here are: * The `coretest` and `collectionstest` crates are just listed as `[[test]]` entires for `cargo test` to naturally pick up. This mean that `cargo test -p core` actually runs all the tests for libcore. * Libraries that aren't tested all mention `test = false` in their `Cargo.toml` * Crates aren't currently allowed to have dev-dependencies due to rust-lang/cargo#860, but we can likely alleviate this restriction once workspaces are implemented. cc rust-lang#31590
alexcrichton
force-pushed
the
rustbuild-crate-tests
branch
from
d11e3c1
to
bb9062a
Compare
|
⌛ Testing commit bb9062a with merge 584f1b5... |
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit bb9062a with merge 7c8476a... |
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
May 12, 2016
… r=brson rustbuild: Add support for crate tests + doctests This commit adds support to rustbuild to run crate unit tests (those defined by `#[test]`) as well as documentation tests. All tests are powered by `cargo test` under the hood. Each step requires the `libtest` library is built for that corresponding stage. Ideally the `test` crate would be a dev-dependency, but for now it's just easier to ensure that we sequence everything in the right order. Currently no filtering is implemented, so there's not actually a method of testing *only* libstd or *only* libcore, but rather entire swaths of crates are tested all at once. A few points of note here are: * The `coretest` and `collectionstest` crates are just listed as `[[test]]` entires for `cargo test` to naturally pick up. This mean that `cargo test -p core` actually runs all the tests for libcore. * Libraries that aren't tested all mention `test = false` in their `Cargo.toml` * Crates aren't currently allowed to have dev-dependencies due to rust-lang/cargo#860, but we can likely alleviate this restriction once workspaces are implemented. cc rust-lang#31590
|
⛄ The build was interrupted to prioritize another pull request. |
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
May 12, 2016
… r=brson rustbuild: Add support for crate tests + doctests This commit adds support to rustbuild to run crate unit tests (those defined by `#[test]`) as well as documentation tests. All tests are powered by `cargo test` under the hood. Each step requires the `libtest` library is built for that corresponding stage. Ideally the `test` crate would be a dev-dependency, but for now it's just easier to ensure that we sequence everything in the right order. Currently no filtering is implemented, so there's not actually a method of testing *only* libstd or *only* libcore, but rather entire swaths of crates are tested all at once. A few points of note here are: * The `coretest` and `collectionstest` crates are just listed as `[[test]]` entires for `cargo test` to naturally pick up. This mean that `cargo test -p core` actually runs all the tests for libcore. * Libraries that aren't tested all mention `test = false` in their `Cargo.toml` * Crates aren't currently allowed to have dev-dependencies due to rust-lang/cargo#860, but we can likely alleviate this restriction once workspaces are implemented. cc rust-lang#31590
bors
added a commit
that referenced
this pull request
May 12, 2016
rustbuild: Add support for crate tests + doctests This commit adds support to rustbuild to run crate unit tests (those defined by `#[test]`) as well as documentation tests. All tests are powered by `cargo test` under the hood. Each step requires the `libtest` library is built for that corresponding stage. Ideally the `test` crate would be a dev-dependency, but for now it's just easier to ensure that we sequence everything in the right order. Currently no filtering is implemented, so there's not actually a method of testing *only* libstd or *only* libcore, but rather entire swaths of crates are tested all at once. A few points of note here are: * The `coretest` and `collectionstest` crates are just listed as `[[test]]` entires for `cargo test` to naturally pick up. This mean that `cargo test -p core` actually runs all the tests for libcore. * Libraries that aren't tested all mention `test = false` in their `Cargo.toml` * Crates aren't currently allowed to have dev-dependencies due to rust-lang/cargo#860, but we can likely alleviate this restriction once workspaces are implemented. cc #31590
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 3, 2023
Enable tests on rustc_codegen_ssa This enables unittests in rustc_codegen_ssa. There are some tests, primarily in [`back/rpath/tests.rs`](https://github.com/rust-lang/rust/blob/HEAD/compiler/rustc_codegen_ssa/src/back/rpath/tests.rs) that haven't ever been running since the unittests are disabled. From what I can tell, this was just a consequence of how things evolved. When testing was initially added in rust-lang#33282, `librustc_trans` had test=false because it didn't have any tests. `rustc_codegen_ssa` eventually split off from that (rust-lang#55627), and the rpath module eventually got merged in too (from `librustc_back` where it used to live). That migration didn't enable the tests. This also includes some fluent diagnostic tests, though I'm not sure what exactly they are testing.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 4, 2023
Enable tests on rustc_codegen_ssa This enables unittests in rustc_codegen_ssa. There are some tests, primarily in [`back/rpath/tests.rs`](https://github.com/rust-lang/rust/blob/HEAD/compiler/rustc_codegen_ssa/src/back/rpath/tests.rs) that haven't ever been running since the unittests are disabled. From what I can tell, this was just a consequence of how things evolved. When testing was initially added in rust-lang#33282, `librustc_trans` had test=false because it didn't have any tests. `rustc_codegen_ssa` eventually split off from that (rust-lang#55627), and the rpath module eventually got merged in too (from `librustc_back` where it used to live). That migration didn't enable the tests. This also includes some fluent diagnostic tests, though I'm not sure what exactly they are testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support to rustbuild to run crate unit tests (those defined by
#[test]) as well as documentation tests. All tests are powered bycargo testunder the hood.
Each step requires the
libtestlibrary is built for that corresponding stage.Ideally the
testcrate would be a dev-dependency, but for now it's just easierto ensure that we sequence everything in the right order.
Currently no filtering is implemented, so there's not actually a method of
testing only libstd or only libcore, but rather entire swaths of crates are
tested all at once.
A few points of note here are:
coretestandcollectionstestcrates are just listed as[[test]]entires for
cargo testto naturally pick up. This mean thatcargo test -p coreactually runs all the tests for libcore.test = falsein theirCargo.tomlDev-dependenciesare not linked when testing subpackages cargo#860, but we can likely alleviate this restriction onceworkspaces are implemented.
cc #31590