-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed expand/collapse shortcut to not conflict with browser shortcuts #33797
Conversation
Allows both `T` and `t`. It had been [Shift]+[+] before.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@@ -124,7 +124,8 @@ | |||
focusSearchBar(); | |||
break; | |||
|
|||
case "+": | |||
case "t": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're writing into the search field, does it expand all sections or not?
Also, I open a new tab with "CTRL+T". Does it expand all sections? |
Can't be t, since its already a well known shortcut. How about e or slash? |
Copying one of @GuillaumeGomez's comments here:
One thing to note - it currently is [Shift] + [+=], rather than just [+=]. If we like that we can leave it. Otherwise any of "e", [?/], or [|] seem fine to me, although [Shift] + [?/] brings up the help screen. |
[Ctrl]+[T] isn't a problem because of these lines. Neither is [Ctrl]+[+] for that matter. The shortcut doesn't work properly at the moment anyway because it's missing |
Realized browsers use [Ctrl]+[+=] for zoom, so using [Shift]+[+=] for collapse/expand was not necessarily a conflict. Also a bugfix.
Thanks! I was only testing on Chrome, so I didn't realize the |
Ah, okay. Could you upload a copy of this running somewhere? |
I'd like to test it as well. |
Good idea. The documentation for |
looks good to me @bors delegate=GuillaumeGomez |
✌️ @GuillaumeGomez can now approve this pull request |
Good for me as well. Thanks @alex-ozdemir! @bors: r+ rollup |
📌 Commit 57ab0ed has been approved by |
T
Changed toggle all sections key to `T` Allows both `T` and `t`. It had been [Shift]+[+] before. In response to rust-lang#33791. cc @Manishearth r? @GuillaumeGomez
Allows both
T
andt
.It had been [Shift]+[+] before.
In response to #33791.
cc @Manishearth
r? @GuillaumeGomez