Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed expand/collapse shortcut to not conflict with browser shortcuts #33797

Merged
merged 2 commits into from
May 25, 2016

Conversation

alex-ozdemir
Copy link
Contributor

Allows both T and t.

It had been [Shift]+[+] before.

In response to #33791.

cc @Manishearth
r? @GuillaumeGomez

Allows both `T` and `t`.

It had been [Shift]+[+] before.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -124,7 +124,8 @@
focusSearchBar();
break;

case "+":
case "t":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're writing into the search field, does it expand all sections or not?

@GuillaumeGomez
Copy link
Member

Also, I open a new tab with "CTRL+T". Does it expand all sections?

@Manishearth
Copy link
Member

Can't be t, since its already a well known shortcut.

How about e or slash?

@alex-ozdemir
Copy link
Contributor Author

alex-ozdemir commented May 23, 2016

Copying one of @GuillaumeGomez's comments here:

Adding another key to the "+" I guess? Something like "SHIFT+'+'" maybe?

One thing to note - it currently is [Shift] + [+=], rather than just [+=]. If we like that we can leave it.

Otherwise any of "e", [?/], or [|] seem fine to me, although [Shift] + [?/] brings up the help screen.

@ollie27
Copy link
Member

ollie27 commented May 23, 2016

[Ctrl]+[T] isn't a problem because of these lines. Neither is [Ctrl]+[+] for that matter.

The shortcut doesn't work properly at the moment anyway because it's missing ev.preventDefault();.

Realized browsers use [Ctrl]+[+=] for zoom, so using [Shift]+[+=] for
collapse/expand was not necessarily a conflict.

Also a bugfix.
@alex-ozdemir
Copy link
Contributor Author

Thanks! I was only testing on Chrome, so I didn't realize the ev.preventDefault() was necessary.

@Manishearth
Copy link
Member

Ah, okay. Could you upload a copy of this running somewhere?

@GuillaumeGomez
Copy link
Member

Ah, okay. Could you upload a copy of this running somewhere?

I'd like to test it as well.

@alex-ozdemir
Copy link
Contributor Author

Good idea.

The documentation for std built with the new version of rustdoc is here.

@Manishearth
Copy link
Member

looks good to me

@bors delegate=GuillaumeGomez

@bors
Copy link
Contributor

bors commented May 23, 2016

✌️ @GuillaumeGomez can now approve this pull request

@GuillaumeGomez
Copy link
Member

Good for me as well. Thanks @alex-ozdemir!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 23, 2016

📌 Commit 57ab0ed has been approved by GuillaumeGomez

@alex-ozdemir alex-ozdemir changed the title Changed toggle all sections key to T Fixed expand/collapse shortcut to not conflict with browser shortcuts May 23, 2016
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 24, 2016
Changed toggle all sections key to `T`

Allows both `T` and `t`.

It had been [Shift]+[+] before.

In response to rust-lang#33791.

cc @Manishearth
r? @GuillaumeGomez
bors added a commit that referenced this pull request May 24, 2016
Rollup of 7 pull requests

- Successful merges: #33692, #33759, #33779, #33781, #33797, #33810, #33832
- Failed merges:
@bors bors merged commit 57ab0ed into rust-lang:master May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants