Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: Use memalign, not posix_memalign, on Android #33832

Merged
merged 1 commit into from
May 28, 2016
Merged

std: Use memalign, not posix_memalign, on Android #33832

merged 1 commit into from
May 28, 2016

Conversation

alexcrichton
Copy link
Member

We've gotten requests to move our Android support as far back as API level 9
where unfortunately the posix_memalign API wasn't implemented yet. Thankfully,
however, the memalign API was and it appears to be usable with free on the
Android platform (see comments included in commit).

This should help fix some of the last few test failures when compiling against
API level 9.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@luqmana
Copy link
Member

luqmana commented May 24, 2016

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 24, 2016

📌 Commit 6584fb4 has been approved by luqmana

@GuillaumeGomez GuillaumeGomez mentioned this pull request May 24, 2016
Merged
@GuillaumeGomez
Copy link
Member

@bors: r-

Some tests failed.

@nagisa
Copy link
Member

nagisa commented May 24, 2016

This is certainly a dangerous commit to put into rollup.

@bors rollup-

@nagisa
Copy link
Member

nagisa commented May 24, 2016

@bors r+ rollup-

Test failure in the rollup seems to have nothing to do with this change.

@bors
Copy link
Contributor

bors commented May 24, 2016

📌 Commit 6584fb4 has been approved by nagisa

@nagisa
Copy link
Member

nagisa commented May 24, 2016

@bors r=luqmana

Err.

@bors
Copy link
Contributor

bors commented May 24, 2016

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented May 24, 2016

📌 Commit 6584fb4 has been approved by luqmana

bors added a commit that referenced this pull request May 24, 2016
@bors
Auto merge of #33833 - GuillaumeGomez:rollup, r=GuillaumeGomez
8393d99 
Rollup of 7 pull requests

- Successful merges: #33692, #33759, #33779, #33781, #33797, #33810, #33832
- Failed merges:
@alexcrichton alexcrichton mentioned this pull request May 24, 2016
Merged
@alexcrichton
Copy link
Member Author

Nominating for beta based on this comment: #33848 (comment)

@alexcrichton alexcrichton added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 24, 2016
@alexcrichton
std: Use memalign, not posix_memalign, on Android
33dfd0f 
We've gotten requests to move our Android support as far back as API level 9
where unfortunately the `posix_memalign` API wasn't implemented yet. Thankfully,
however, the `memalign` API was and it appears to be usable with `free` on the
Android platform (see comments included in commit).

This should help fix some of the last few test failures when compiling against
API level 9.
@alexcrichton
Copy link
Member Author

@bors: r=luqmana 33dfd0f

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 26, 2016
@nikomatsakis
Copy link
Contributor

Unclear that we are the right team to make this call, but the compiler team approves backporting to beta. :) Ordinarily we wouldn't backport this change, but since it helps with the bot infrastructure, seems fine.

@alexcrichton
Copy link
Member Author

Oh right, yes sorry I intended to discuss this with the tools team this coming triage meeting.

@Manishearth Manishearth mentioned this pull request May 28, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request May 28, 2016
@Manishearth
Rollup merge of rust-lang#33832 - alexcrichton:android-memalign, r=lu…
320dd04 
…qmana

std: Use memalign, not posix_memalign, on Android

We've gotten requests to move our Android support as far back as API level 9
where unfortunately the `posix_memalign` API wasn't implemented yet. Thankfully,
however, the `memalign` API was and it appears to be usable with `free` on the
Android platform (see comments included in commit).

This should help fix some of the last few test failures when compiling against
API level 9.
bors added a commit that referenced this pull request May 28, 2016
@bors
Auto merge of #33927 - Manishearth:rollup, r=Manishearth
f1776fe 
Rollup of 15 pull requests

- Successful merges: #33820, #33821, #33822, #33824, #33825, #33831, #33832, #33848, #33849, #33852, #33854, #33856, #33859, #33860, #33861
- Failed merges:
@bors bors merged commit 33dfd0f into rust-lang:master May 28, 2016
@alexcrichton alexcrichton deleted the android-memalign branch May 31, 2016 21:07
@alexcrichton alexcrichton mentioned this pull request May 31, 2016
Merged
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 31, 2016
@sanxiyn sanxiyn mentioned this pull request Oct 7, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@alexcrichton @rust-highfive @luqmana @bors @GuillaumeGomez @nagisa @nikomatsakis @brson