Propagate obligations through projection #33822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // FIXME(#32730) propagate obligations (fn pointer vtable nested obligations ONLY come from | ||
| // unification in inference) | ||
| // FIXME(#32730) drop this assertion once obligations are propagated from inference (fn pointer | ||
| // vtable nested obligations ONLY come from unification in inference) | ||
| assert!(fn_pointer_vtable.nested.is_empty()); |
There was a problem hiding this comment.
note that in the "thread vtable-closure obligations to result" commit of #33816 I fixed a bug -- probably introduced by me -- where the comparable vtable.nested obligations were being totally ignored in the fn below
|
@bors r+ |
|
📌 Commit 808e431 has been approved by |
|
this will conflict with #33816 but the rebase should be easy enough... |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 28, 2016
…nikomatsakis Propagate obligations through projection Up next: generating region obligations in inference. r? @nikomatsakis
bors
added a commit
that referenced
this pull request
May 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up next: generating region obligations in inference.
r? @nikomatsakis