Rollup of 5 pull requests #33965
Merged
Rollup of 5 pull requests #33965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically reverts rust-lang#25508. The `is_dir()` function has been stable since 1.5.0.
…illaumeGomez print enum variant fields in docs Right now we are repeating enum variants at the top, because the fields aren't shown with the actual docs. It's very annoying to have to scroll up and down to have both docs and field info. For struct variants we already list the fields. enum docs look like this after this PR:  There are degenerate cases for enum tuple variants with lots of fields:  I was thinking that we could move the docs below the variant (slightly indented) or list the variant fields vertically instead of horizontally r? @steveklabnik
Fix the span of generated `#[derive_*]` attributes Fixes rust-lang#33571. r? @nrc
…r=nrc run rustfmt on librustc_llvm folder
Use Path::is_dir() in fs::read_dir()'s example. Basically reverts rust-lang#25508. The `is_dir()` function has been stable since 1.5.0.
…hearth Move driver::Resolutions::def_map out of its RefCell.
|
@bors r+ p=10 |
|
📌 Commit 26c2098 has been approved by |
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors force |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[derive_*]attributes #33926, run rustfmt on librustc_llvm folder #33942, Use Path::is_dir() in fs::read_dir()'s example. #33958, Move driver::Resolutions::def_map out of its RefCell. #33964