Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo (privledge->privilege) #34941

Merged
merged 2 commits into from Aug 15, 2016
Merged

Fix typo (privledge->privilege) #34941

merged 2 commits into from Aug 15, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jul 20, 2016

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@apasel422
Copy link
Contributor

@bors: r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Jul 20, 2016

📌 Commit e91b625 has been approved by apasel422

@apasel422
Copy link
Contributor

@bors: r-

@steveklabnik
Copy link
Member

Gah! Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jul 20, 2016

📌 Commit e91b625 has been approved by steveklabnik

@@ -526,7 +526,7 @@ pub fn temp_dir() -> PathBuf {
/// Ok("/home/alex/bar")
/// ```
///
/// This sort of behavior has been known to [lead to privledge escalation] when
/// This sort of behavior has been known to [lead to privilege escalation] when
/// used incorrectly, for example.
///
/// [lead to privledge escalation]: http://securityvulns.com/Wdocument183.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update this too, so that the link still works?

@steveklabnik
Copy link
Member

@bors: r-

whoops, @apasel422 i will let you have this PR, I didn't see that. lol!

@apasel422
Copy link
Contributor

@qolop Are you still interested in fixing this?

Didn't see this one at first.
@ghost
Copy link
Author

ghost commented Aug 11, 2016

@apasel422 Sorry about that, I have just fixed the second typo.

@apasel422
Copy link
Contributor

@bors: r+ rollup

Thanks @qolop!

@bors
Copy link
Contributor

bors commented Aug 11, 2016

📌 Commit 629f2aa has been approved by apasel422

eddyb added a commit to eddyb/rust that referenced this pull request Aug 14, 2016
eddyb added a commit to eddyb/rust that referenced this pull request Aug 14, 2016
bors added a commit that referenced this pull request Aug 14, 2016
@bors bors merged commit 629f2aa into rust-lang:master Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants