-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update E0070 to new error format #35615
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Aatch (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
closed for now, need to fix the unit tests. |
Fixing tidy error |
Thanks for the PR! Can you do squash your 3 commits down to 1 commit? With that, I think we're good. |
Thanks Jonathan, just squashed them into 1! @jonathandturner |
Great! Looks good. @bors r+ rollup |
📌 Commit 4ab00e4 has been approved by |
… r=jonathandturner Update E0070 to new error format Updated E0070 to new error format. Part of rust-lang#35233 Fixes rust-lang#35503 Thanks for letting me help! r? @jonathandturner
… r=jonathandturner Update E0070 to new error format Updated E0070 to new error format. Part of rust-lang#35233 Fixes rust-lang#35503 Thanks for letting me help! r? @jonathandturner
… r=jonathandturner Update E0070 to new error format Updated E0070 to new error format. Part of rust-lang#35233 Fixes rust-lang#35503 Thanks for letting me help! r? @jonathandturner
Rollup of 30 pull requests - Successful merges: #34941, #35392, #35444, #35447, #35491, #35533, #35539, #35558, #35573, #35574, #35577, #35586, #35588, #35594, #35596, #35597, #35598, #35606, #35611, #35615, #35616, #35620, #35622, #35640, #35643, #35644, #35646, #35647, #35648, #35661 - Failed merges: #35395, #35415
☔ The latest upstream changes (presumably #35666) made this pull request unmergeable. Please resolve the merge conflicts. |
Updated E0070 to new error format.
Part of #35233
Fixes #35503
Thanks for letting me help!
r? @jonathandturner