Turn the RFC1592 warnings into hard errors #34982
Conversation
|
Started a crater run comparing |
|
Crater run yielded 43 regressions, but it seems probably many are false positives (haven't investigated yet): https://gist.github.com/nikomatsakis/9006df8ddc4cee518d38732cacfe8e7c |
|
Most of them are timeouts / SSL errors. |
|
I will try to do another crater run since the timeout / SSL problems should be less bad now. In the meantime: cc @daggerbot @srijs @rphmeier @james-darkfox @bluss @jneem @davll @workanator, crates of yours might be affected by this upcoming bugfix! The changes needed though are pretty small for the most part. |
|
@nikomatsakis thanks for the heads up (fixed in jobsteal 0.5.1) |
arielb1
force-pushed
the
bad-tuples-and-objects
branch
from
8c94415
to
31a11f0
Compare
|
Thanks for the heads up, ndarray was fixed in version 0.5.1 (which was released in april 2016). |
|
(My next attempt at a crater run failed again, btw, and I'm not entirely sure why.) |
|
I'll give crater a shot. |
|
I re-ran crater and got this report: https://gist.github.com/nikomatsakis/41f3a69b6b37a65a2575eba69c716aed |
|
That report shows 12 root regressions and 18 total. However, those root regressions are not actually root regressions -- many of them seem to be from dependent crates, and I think that most of those are outdated versions where a fix is available. Here is a categorization:
One non-data-point:
|
|
I would like feedback from @rust-lang/core / @rust-lang/compiler members. Basically these are two warnings that were made for oversights in the type system. Most crates seem to work but there are some regressions. More homework is needed, I think, to verify which of these are outdated crates, and to make sure all owners are contacted. Other than that, I think we should go ahead and convert these warnings into errors, particularly since the infrastructure for them is painful to maintain. We could however take intermediate steps instead -- convert to deny-by-default? I'm trying to get a feeling for when it is appropriate to "throw the switch". |
Along these lines, it's really tedious to comb through crater results right now. There has to be a way to make this more automated. |
|
@nikomatsakis thank you for letting know. Will fix my crate. |
|
@nikomatsakis I get rid of |
|
@workanator great! :) |
|
OK, so I decided that we should land this, but only once the crates we identified are all either fixed or have pending PRs. To that end, I opened up for vectormath https://github.com/davll/vectormath-rs/pull/6, but I didn't get to the others yet. One weird thing I found is that the |
|
@nikomatsakis just to recap, these warnings have hit stable, right? If so, how many releases? We have a new release coming out a week from today, so it may be worth waiting a week to miss the beta train as well perhaps? (would give an extra cycle with these as stable warnings). Given the low impact, ease of fixing, burden on the compiler, and analysis, I'd personally be fine turning into hard errors. |
|
☔ The latest upstream changes (presumably #35592) made this pull request unmergeable. Please resolve the merge conflicts. |
I believe so, but I'm not sure how many releases. Would be good to verify.
Makes sense; I'd still prefer if we have PRs up. It's not that many repos. Though it takes a surprisingly long time to "context switch" around. I'm still a bit confused why I don't get any warnings for the |
|
I tried to make a PR for lense but the current master has a bunch of (unrelated) compilation errors, from what I can see. cc @trustless-fox -- warning that we will be converting some future-compat warnings that may or may not affect your current code into hard errors. =) |
|
I could not find the repository for aurum-numeric anymore. cc @daggerbot -- the existing version of this crate on crates.io may be affected by this bugfix here, which will be converted soon from a warning into an error. See #33242 for details! :) |
|
OK, I checked off all the broken crates, but @arielb1 it looks like we need a rebase here. If you rebase, r=me! :) |
arielb1
force-pushed
the
bad-tuples-and-objects
branch
from
31a11f0
to
86f41e8
Compare
|
@bors r+ |
|
📌 Commit 86f41e8 has been approved by |
|
⌛ Testing commit 86f41e8 with merge 1072f84... |
|
💔 Test failed - auto-mac-64-opt |
The warnings have already reached stable The test rfc1592_deprecated is covered by `bad_sized` and `unsized6`. Fixes rust-lang#33242 Fixes rust-lang#33243
arielb1
force-pushed
the
bad-tuples-and-objects
branch
from
86f41e8
to
7b92d05
Compare
|
I managed to revert an LLVM upgrade. Un-revert it. @bors r=nikomatsakis |
|
📌 Commit 7b92d05 has been approved by |
Turn the RFC1592 warnings into hard errors The warnings have already reached stable, and I want to improve the trait error reporting code. Turning warnings into errors, this is obviously a [breaking-change]. r? @nikomatsakis cc @rust-lang/compiler
|
@nikomatsakis Please remove |
|
@james-darkfox very good. I can't easily remove from the tests, but I'll try to remember not to bother you. ;) |
|
@nikomatsakis Does it iterate over crates.io ? I could send a dummy crate. If it checks git, then that repo will be removed soon anyway. Thanks; and keep sure to bother me if anything else breaks! :-) |
The warnings have already reached stable, and I want to improve the trait error reporting code.
Turning warnings into errors, this is obviously a [breaking-change].
r? @nikomatsakis
cc @rust-lang/compiler