Rollup of 23 pull requests #35592
Merged
Rollup of 23 pull requests #35592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix note message, fix tests.
added 7 commits
August 11, 2016 06:34
Add tracking issue for `String::insert_str`
…t, r=jonathandturner E0128 update error format Fixes rust-lang#35508 Part of rust-lang#35233 r? @jonathandturner
E0263 updated to new format. Fixes rust-lang#35518. Part of rust-lang#35233. r? @jonathandturner
Remove redundant `&mut ref mut` in doc for Result::as_mut() While a good example of how `&mut ref mut` is a no-op, I don't think we should show that here :) See https://users.rust-lang.org/t/mnemonic-for-reading-qualifiers/6853 r? @steveklabnik
Update E0133 to new format Part of rust-lang#35233 Fix rust-lang#35509 r? @jonathandturner
Fix docs typo in std::os::unix::net::SocketAddr::is_unnamed
…t, r=jonathandturner E0072 update error format Part of rust-lang#35233 Fixes rust-lang#35506 r? @jonathandturner The bonus for this issue currently seems to be impossible to do reliably, as the compiler seems to lack span information for item names alone, like `Foo` in `struct Foo { ... }`. It would be possible to hack something together by computing span offsets, but that seems like a solution that would be begging for trouble. A proper solution to this would, of course, be to add span information to the right place (seems to be `rustc::hir::Item::name` but I may be wrong).
|
@bors r+ p=1 |
|
📌 Commit cdedad5 has been approved by |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit cdedad5 with merge 0bf2360... |
|
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
|
@bors r+ p=1 |
|
📌 Commit d3af9a3 has been approved by |
|
💔 Test failed - auto-linux-64-debug-opt |
|
Timed out... @bors retry |
This was referenced Aug 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainfunctions in doc examples. #35482, Shrink span to variant discriminant expression for E0081 #35486, Add test for issue #29053 #35505, Update Error Format for E0091 and E0092 #35528, Update E0008 and E0007 to new format #35530, Do not span across nodes for E0004 #35532, Updated E0433 to new error message. (no bonus) #35536, Update E0038 to the new error format #35537, Updated E0045 to new error format (no bonus) #35541, Update error message E0384 to new format #35552, Add tracking issue forString::insert_str#35554, E0128 update error format #35555, E0263 updated to new format. #35557, Remove redundant&mut ref mutin doc for Result::as_mut() #35562, Update E0133 to new format #35565, Fix docs typo in std::os::unix::net::SocketAddr::is_unnamed #35569, E0072 update error format #35576