-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run rustfmt on compiletest folder in src/tools/ folder #35448
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
cc @nrc |
|
||
let primary_spans: Vec<_> = spans_in_this_file.iter() | ||
.cloned() | ||
.filter(|span| span.is_primary) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nrc how does rustfmt decide when to align to .
in a method-call chain? Or does it just never do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It uses block indent atm. This has been something of a tricky point - we used to use visual indent which looked pretty but caused pretty bad rightward drift and caused problems with closures, so now we always use block indent which doesn't look as good, but does work well with others. Hopefully we can improve it further in the future
@bors r+ |
📌 Commit abe1cc7 has been approved by |
@bors rollup |
…omatsakis run rustfmt on compiletest folder in src/tools/ folder
…omatsakis run rustfmt on compiletest folder in src/tools/ folder
…omatsakis run rustfmt on compiletest folder in src/tools/ folder
No description provided.