Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run rustfmt on compiletest folder in src/tools/ folder #35448

Merged
merged 1 commit into from
Aug 12, 2016
Merged

run rustfmt on compiletest folder in src/tools/ folder #35448

merged 1 commit into from
Aug 12, 2016

Conversation

srinivasreddy
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@srinivasreddy
Copy link
Contributor Author

cc @nrc

@srinivasreddy
Copy link
Contributor Author

r? @nikomatsakis

@rust-highfive rust-highfive assigned nikomatsakis and unassigned aturon Aug 9, 2016

let primary_spans: Vec<_> = spans_in_this_file.iter()
.cloned()
.filter(|span| span.is_primary)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nrc how does rustfmt decide when to align to . in a method-call chain? Or does it just never do it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses block indent atm. This has been something of a tricky point - we used to use visual indent which looked pretty but caused pretty bad rightward drift and caused problems with closures, so now we always use block indent which doesn't look as good, but does work well with others. Hopefully we can improve it further in the future

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 9, 2016

📌 Commit abe1cc7 has been approved by nikomatsakis

@nikomatsakis
Copy link
Contributor

@bors rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 10, 2016
…omatsakis

run rustfmt on compiletest folder in src/tools/ folder
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 10, 2016
…omatsakis

run rustfmt on compiletest folder in src/tools/ folder
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 11, 2016
…omatsakis

run rustfmt on compiletest folder in src/tools/ folder
bors added a commit that referenced this pull request Aug 11, 2016
@bors bors merged commit abe1cc7 into rust-lang:master Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants