Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E0008 and E0007 to new format #35530

Merged
merged 2 commits into from
Aug 12, 2016
Merged

Update E0008 and E0007 to new format #35530

merged 2 commits into from
Aug 12, 2016

Conversation

srdja
Copy link

@srdja srdja commented Aug 8, 2016

Part of #35233
A fix for #35496

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@arielb1
Copy link
Contributor

arielb1 commented Aug 8, 2016

Could you also change the 2 nearby errors?

@srdja
Copy link
Author

srdja commented Aug 8, 2016

@arielb1

Sure, I can fix E0007 (@devshep is working on E0009), but I'd like to get some feedback from @jonathandturner first.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 8, 2016

@srdja - I'll sign you up for E0007 so you can fix that one. @devshep can fix E0009. They're close together, but it's okay for multiple people to work on different ones.

@srdja srdja changed the title Update E0008 to new format Update E0008 and E0007 to new format Aug 9, 2016
@srdja
Copy link
Author

srdja commented Aug 9, 2016

@jonathandturner - I've updated E0007.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 9, 2016

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 9, 2016

📌 Commit aa40ec7 has been approved by jonathandturner

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 10, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 10, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 11, 2016
bors added a commit that referenced this pull request Aug 11, 2016
@bors bors merged commit aa40ec7 into rust-lang:master Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants