Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e0017 to new format #35445

Merged
merged 1 commit into from
Aug 12, 2016
Merged

Conversation

pcn
Copy link
Contributor

@pcn pcn commented Aug 7, 2016

Updated span_err! to use struct_span_err! and provide a span_label that describes the error in context.

Updated the test to look for the span_labels that are provided now.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@pcn
Copy link
Contributor Author

pcn commented Aug 7, 2016

This is for #35195

- Fix note message, fix tests.
@pcn pcn force-pushed the update-E0017-to-new-format branch from 51d8254 to ec1ef79 Compare August 7, 2016 14:30
@arielb1
Copy link
Contributor

arielb1 commented Aug 8, 2016

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 8, 2016

📌 Commit ec1ef79 has been approved by arielb1

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 10, 2016
…rielb1

Update e0017 to new format

Updated `span_err!` to use `struct_span_err!` and provide a `span_label` that describes the error in context.

Updated the test to look for the `span_label`s that are provided now.
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 10, 2016
…rielb1

Update e0017 to new format

Updated `span_err!` to use `struct_span_err!` and provide a `span_label` that describes the error in context.

Updated the test to look for the `span_label`s that are provided now.
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 11, 2016
…rielb1

Update e0017 to new format

Updated `span_err!` to use `struct_span_err!` and provide a `span_label` that describes the error in context.

Updated the test to look for the `span_label`s that are provided now.
bors added a commit that referenced this pull request Aug 11, 2016
@bors bors merged commit ec1ef79 into rust-lang:master Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants