Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #35127

Merged
merged 18 commits into from
Jul 30, 2016
Merged

Rollup of 8 pull requests #35127

merged 18 commits into from
Jul 30, 2016

Commits on Jul 27, 2016

  1. If a single import resolves to an inaccessible name in some but not a…

    …ll namespaces,
    
    avoid importing the name in the inaccessible namespaces.
    
    Currently, the inaccessible namespaces are imported but cause a privacy error when used.
    jseyfried committed Jul 27, 2016
    Configuration menu
    Copy the full SHA
    132bff9 View commit details
    Browse the repository at this point in the history
  2. Fix fallout in tests.

    jseyfried committed Jul 27, 2016
    Configuration menu
    Copy the full SHA
    8205691 View commit details
    Browse the repository at this point in the history
  3. Add test for string AddAssign

    Knight committed Jul 27, 2016
    Configuration menu
    Copy the full SHA
    6ac83de View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2016

  1. Rename _ to {numerics} for unknown numeric types

    Jonathan Turner committed Jul 28, 2016
    Configuration menu
    Copy the full SHA
    cfdaca0 View commit details
    Browse the repository at this point in the history
  2. Add non-panicking abs() functions to all signed integer types.

    Currently, calling abs() on one of the signed integer types might panic (in
    debug mode at least) because the absolute value of the largest negative value
    can not be represented in that signed type. Unlike all other integer
    operations, there is currently not a non-panicking version on this function.
    This seems to just be an oversight in the design, therefore just adding it now.
    Jethro Beekman committed Jul 28, 2016
    Configuration menu
    Copy the full SHA
    cdc6afe View commit details
    Browse the repository at this point in the history
  3. Move to {integer} and {float}

    Jonathan Turner committed Jul 28, 2016
    Configuration menu
    Copy the full SHA
    ea77049 View commit details
    Browse the repository at this point in the history
  4. Revert "Remove unused methods from MultiSpan"

    This reverts commit f7019a4.
    
    This removed the only way to make a suggestion with more than one
    substitute. Bring it back until we come up with a better solution.
    mcarton committed Jul 28, 2016
    Configuration menu
    Copy the full SHA
    6dc98cf View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2016

  1. Configuration menu
    Copy the full SHA
    f459e80 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2a41b31 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    415fde4 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2016

  1. Rollup merge of rust-lang#35049 - knight42:add-test, r=alexcrichton

    Add a test for AddAssign on String
    
    Fix rust-lang#35047
    Manishearth authored Jul 30, 2016
    Configuration menu
    Copy the full SHA
    96e3972 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#35058 - jethrogb:no_panic_abs, r=alexcrichton

    Add non-panicking abs() functions to all signed integer types.
    
    Currently, calling abs() on one of the signed integer types might panic (in
    debug mode at least) because the absolute value of the largest negative value
    can not be represented in that signed type. Unlike all other integer
    operations, there is currently not a non-panicking version on this function.
    This seems to just be an oversight in the design, therefore just adding it now.
    Manishearth authored Jul 30, 2016
    Configuration menu
    Copy the full SHA
    6234610 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#35063 - jseyfried:avoid_importing_inaccessi…

    …ble_names, r=nrc
    
    resolve: Exclude inaccessible names from single imports
    
    If a single import resolves to an inaccessible name in some but not all namespaces, avoid importing the name in the inaccessible namespaces.
    
    Currently, the inaccessible namespaces are imported but cause a privacy error when used.
    
    r? @nrc
    Manishearth authored Jul 30, 2016
    Configuration menu
    Copy the full SHA
    8c6421f View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#35080 - jonathandturner:fix_numeric_expecte…

    …d_found, r=nikomatsakis
    
    Rename _ to {integer} and {float} for unknown numeric types
    
    This PR renames _ to {integer} or {float} for unknown numeric types, to help people parse error messages that have numeric types that haven't been nailed down.
    
    Example:
    ```rust
    fn main() {
        let x: String = 4;
    }
    ```
    
    Before:
    ```
    error[E0308]: mismatched types
     --> quicktest.rs:2:21
      |
    2 |     let x: String = 4;
      |                     ^ expected struct `std::string::String`, found integral variable
      |
      = note: expected type `std::string::String`
      = note:    found type `_`
    
    error: aborting due to previous error
    ```
    
    after:
    ```
    error[E0308]: mismatched types
     --> quicktest.rs:2:21
      |
    2 |     let x: String = 4;
      |                     ^ expected struct `std::string::String`, found integral variable
      |
      = note: expected type `std::string::String`
      = note:    found type `{integer}`
    
    error: aborting due to previous error
    ```
    ```
    Manishearth authored Jul 30, 2016
    Configuration menu
    Copy the full SHA
    26e22b8 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#35090 - michaelwoerister:get-rid-of-id-visi…

    …tor, r=eddyb
    
    intravisit: Fold functionality of IdVisitor into the regular Visitor.
    Manishearth authored Jul 30, 2016
    Configuration menu
    Copy the full SHA
    e649a25 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#35094 - mcarton:multispan, r=jonathandturner

    Revert "Remove unused methods from MultiSpan"
    
    This reverts commit f7019a4.
    
    That commit removed the only way to make a suggestion with more than one substitute. That feature is not used directly by rustc but exists and is used by Clippy. Bring it back until we come up with a better solution (suggestions don't use span labels, so it would make sense for them to use their own type).
    Rational there: https://github.com/Manishearth/rust-clippy/pull/1119.
    
    r? @jonathandturner
    Cc @Manishearth
    Manishearth authored Jul 30, 2016
    Configuration menu
    Copy the full SHA
    6ea3ef7 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#35104 - frewsxcv:linked-list-append, r=stev…

    …eklabnik
    
    Rewrite `collections::LinkedList::append` doc example.
    
    None
    Manishearth authored Jul 30, 2016
    Configuration menu
    Copy the full SHA
    ce79972 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#35106 - xen0n:issue-35082, r=alexcrichton

    syntax_ext: format: fix ICE with bad named arguments
    
    Fixes rust-lang#35082 by guarding against a new case of malformed invocation not previously covered.
    
    r? @alexcrichton
    Manishearth authored Jul 30, 2016
    Configuration menu
    Copy the full SHA
    0b64a56 View commit details
    Browse the repository at this point in the history