Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated E0071 to new format. #35285

Merged
merged 1 commit into from
Aug 5, 2016

Conversation

razielgn
Copy link
Contributor

@razielgn razielgn commented Aug 4, 2016

Bonus: the span underlines only the name of the thing that's not a struct rather than the whole expression.

Part of #35233.
Fixes #35220.

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

Can you also update src/test/compile-fail/trait-as-struct-constructor.rs to use the new label? With that, I'd be happy to approve.

The span underlines only the name of the thing that's not a struct rather
than the whole expression.
@razielgn
Copy link
Contributor Author

razielgn commented Aug 4, 2016

@jonathandturner sorry, I forgot it. 😄 Updated!

@razielgn razielgn force-pushed the updated-e0071-to-new-format branch from 4b4836e to 7c58b26 Compare August 4, 2016 15:27
@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

Great, thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 4, 2016

📌 Commit 7c58b26 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 4, 2016
…t, r=jonathandturner

Updated E0071 to new format.

Bonus: the span underlines only the name of the thing that's not a struct rather than the whole expression.

Part of rust-lang#35233.
Fixes rust-lang#35220.

r? @jonathandturner
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 4, 2016
…t, r=jonathandturner

Updated E0071 to new format.

Bonus: the span underlines only the name of the thing that's not a struct rather than the whole expression.

Part of rust-lang#35233.
Fixes rust-lang#35220.

r? @jonathandturner
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 5, 2016
…t, r=jonathandturner

Updated E0071 to new format.

Bonus: the span underlines only the name of the thing that's not a struct rather than the whole expression.

Part of rust-lang#35233.
Fixes rust-lang#35220.

r? @jonathandturner
bors added a commit that referenced this pull request Aug 5, 2016
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 5, 2016
…t, r=jonathandturner

Updated E0071 to new format.

Bonus: the span underlines only the name of the thing that's not a struct rather than the whole expression.

Part of rust-lang#35233.
Fixes rust-lang#35220.

r? @jonathandturner
bors added a commit that referenced this pull request Aug 5, 2016
@bors bors merged commit 7c58b26 into rust-lang:master Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants