Rollup of 25 pull requests #35321
Closed
Rollup of 25 pull requests #35321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use make check-lexer to verify the grammar. * Extend grammar/README * Add make clean-grammar rule * Add target check-build-lexer-verifier to make tidy, so it will build the verifier with every build and catch future errors
Beginners may try to adapt the tutorial to develop their own code. When using different dependencies, they may use the wildcard for versioning. Since they are new to the language, they will not know that the wildcard asterisk is a string, not a token. Make the correct format more explicit, to remove one potential source of frustration.
This is a partial fix for issue rust-lang#34808. Most of the wording was copied verbatim from the RFC. Main difference is that I moved the actual template to the top of the section. It also makes the error explanations the longest section in the guidelines doc for now.
This adds a question and answer to the Q&A section of the Copy docs. Specifically, it asks the question I asked while reading the docs, and gives its answer.
Was surprised to learn that heaps were used in this way, then realized upon reading [the linked paper](http://www.cs.cmu.edu/afs/cs/academic/class/15213-f98/doc/dsa.pdf) that it's a totally different type of heap—an important distinction.
There is no longer a `Repr` trait, so mentioning a missing impl of it was potentially confusing.
…annotation to match other files.
Add Derive not possible question to Copy This adds a question and answer to the Q&A section of the Copy docs. Specifically, it asks the question I asked while reading the docs, and gives its answer. cc @steveklabnik
…eveklabnik Add doc examples for FileType struct Part of rust-lang#29356. r? @steveklabnik
Add io::Error doc examples Fixes rust-lang#29359. r? @steveklabnik
…klabnik Provide more explicit example of wildcard version in guessing game doc. Beginners may try to adapt the tutorial to develop their own code. When using different dependencies, they may use the wildcard for versioning. Since they are new to the language, they will not know that the wildcard asterisk is a string, not a token. Make the correct format more explicit, to remove one potential source of frustration.
A couple `std::net` doc improvements. None
Add doc example for Vec Fixes rust-lang#29380. r? @steveklabnik
Add doc example for `std::ffi::NulError::nul_position`. None
Update the-stack-and-the-heap.md Was surprised to learn that heaps were used in this way, then realized upon reading [the linked paper](http://www.cs.cmu.edu/afs/cs/academic/class/15213-f98/doc/dsa.pdf) that it's a totally different type of heap—an important distinction.
…labnik Doc `std::thread::park_timeout` r? @steveklabnik
…thandturner E0132 update Fixes rust-lang#35258. r? @jonathandturner
…-format, r=jonathandturner E0109 Update error format Fixes rust-lang#35247 as part of rust-lang#35233. r? @jonathandturner
Clean up `std::raw` docs There is no longer a `Repr` trait, so mentioning a missing impl of it was potentially confusing. r? @steveklabnik
…t, r=jonathandturner Updated E0071 to new format. Bonus: the span underlines only the name of the thing that's not a struct rather than the whole expression. Part of rust-lang#35233. Fixes rust-lang#35220. r? @jonathandturner
… r=jonathandturner E0060 e0061 format update This fixes rust-lang#35215 and fixes rust-lang#35216 as part of rust-lang#35233 A separate issue will be opened to track the bonus portion of the tickets as @jaredwy will be handling that part. ?r @jonathandturner
Update E0079 to new format Fixes rust-lang#35222. Part of rust-lang#35233. r? @GuillaumeGomez
…mat, r=jonathandturner Update error message for E0172 Fixes rust-lang#35272 as part of rust-lang#35233. r? @jonathandturner
Update error message E0178 Fixes rust-lang#35273 as part of rust-lang#35233.
Set label for unreachable pattern Part of rust-lang#35233 Fixes rust-lang#35190 r? @jonathandturner
Update error message E0120 Fixes rust-lang#35253 as part of rust-lang#35233. r? @jonathandturner
…t, r=jonathandturner E0110 update error format Fixes rust-lang#35248 Part of rust-lang#35233 r? @jonathandturner
…urner Update E0124 to the new error format Part of rust-lang#35233. This resolves rust-lang#35255. r? @jonathandturner
|
@bors: r+ p=1 |
|
📌 Commit 60c1910 has been approved by |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
lol @jonathandturner beat me by SECONDS #35320 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
range::RangeArgument::{start,end}. #35041, Add Derive not possible question to Copy #35042, Add doc examples for FileType struct #35076, Add io::Error doc examples #35109, Provide more explicit example of wildcard version in guessing game doc. #35137, A couplestd::netdoc improvements. #35175, Add doc example for Vec #35181, Add doc example forstd::ffi::NulError::nul_position. #35182, Update the-stack-and-the-heap.md #35189, Docstd::thread::park_timeout#35239, E0132 update #35264, E0109 Update error format #35266, Clean upstd::rawdocs #35281, Updated E0071 to new format. #35285, E0060 e0061 format update #35289, Update E0079 to new format #35291, Update error message for E0172 #35294, Update error message E0178 #35296, Set label for unreachable pattern #35297, Update error message E0120 #35298, E0110 update error format #35299, Update E0124 to the new error format #35318