Update E0010 to use the new format

[pcn]

For #35194

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[sophiajt]

Great! Next make sure you also update the unit test so that you're testing to make sure that new label is there.

[pcn]

Ah, yes. Thanks for reminding me about that. I'll also revert the message to the recommended message from #35194. It seems like I riff'd here.

[pcn]

It looks like like the existing test is only matching on the string E0010 so no change needs to be made there:

spacey@masonjar:~/dvcs/github/rust-lang/rust$ python src/bootstrap/bootstrap.py --step check-cfail E0010 --stage 1
Building stage0 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Building stage0 test artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Building stage1 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Building stage1 test artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Building stage1 tool compiletest (x86_64-unknown-linux-gnu)
Check compiletest compile-fail (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

running 1 test
test [compile-fail] compile-fail/E0010.rs ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured

Build completed in 0:00:01

And I've changed the inline message to match the top line message, which is what the request actually asked for:

spacey@masonjar:~/dvcs/github/rust-lang/rust$ RUST_NEW_ERROR_FORMAT=true ./build/x86_64-unknown-linux-gnu/stage1/bin/rustc src/test/compile-fail/E0010.rs
error[E0010]: allocations are not allowed in constants
  --> src/test/compile-fail/E0010.rs:13:24
   |
13 | const CON : Box<i32> = box 0; //~ ERROR E0010
   |                        ^^^^^ allocation not allowed in constants

error: aborting due to previous error

[sophiajt]

There are some quirks in the test runner. I talk about them in the "Extra credit" section of the blog post. You'll need to add at least one NOTE to the test for it to start checking that the label is there.

Once you add that NOTE, you can know that it's at least being tested. With that, I think we'll be good to go.

Btw, thanks for fixing my grammar :)

[pcn]

OK, looks like I skimmed that part when I focused on the tips section below. I'm looking into adding a NOTE now.

[pcn]

Tested a bogus NOTE and then this NOTE and it looks as though it's now working as expected.

[sophiajt]

Great. Can you squash your three 3 commits down to 1 commit? With that I think we'll be ready.

[pcn]

Rebased.

[sophiajt]

Great!

@bors r+ rollup

[bors]

📌 Commit dfb66c3 has been approved by jonathandturner