Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update E0205 to the new error format #35468

Merged
merged 1 commit into from
Aug 7, 2016
Merged

Update E0205 to the new error format #35468

merged 1 commit into from
Aug 7, 2016

Conversation

munyari
Copy link
Contributor

@munyari munyari commented Aug 7, 2016

Part of #35233

Addresses #35382
"r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 7, 2016

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 7, 2016

📌 Commit 0b248f1 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Rollup merge of rust-lang#35468 - munyari:e0205, r=jonathandturner
995eeb0 
Update E0205 to the new error format

Part of rust-lang#35233

Addresses rust-lang#35382
"r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 7, 2016
Merged
@munyari
Copy link
Contributor Author

munyari commented Aug 7, 2016

@jonathandturner how could I shrink the span label to only cover Copy in your example?

@sophiajt
Copy link
Contributor

sophiajt commented Aug 7, 2016

It's going to be different for areas in the compiler, but you can get some ideas from https://github.com/rust-lang/rust/pull/35454/files and https://github.com/rust-lang/rust/pull/35372/files

bors added a commit that referenced this pull request Aug 7, 2016
@bors
Auto merge of #35469 - jonathandturner:rollup, r=jonathandturner
1744c46 
Rollup of 21 pull requests

- Successful merges: #35314, #35355, #35357, #35366, #35394, #35410, #35411, #35413, #35417, #35419, #35421, #35429, #35433, #35434, #35436, #35439, #35443, #35454, #35455, #35467, #35468
- Failed merges: #35395, #35415
@bors bors merged commit 0b248f1 into rust-lang:master Aug 7, 2016
@KiChjang KiChjang mentioned this pull request Aug 8, 2016
Merged
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 8, 2016
Rollup merge of rust-lang#35484 - KiChjang:e0205-bonus, r=GuillaumeGomez
a72891e 
Shrink E0205 span label to the trait being implemented

Part of rust-lang#35233.
Extension of rust-lang#35468.
Closes rust-lang#35382.

r? @GuillaumeGomez
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 10, 2016
@steveklabnik
Rollup merge of rust-lang#35484 - KiChjang:e0205-bonus, r=GuillaumeGomez
a8d123b 
Shrink E0205 span label to the trait being implemented

Part of rust-lang#35233.
Extension of rust-lang#35468.
Closes rust-lang#35382.

r? @GuillaumeGomez
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sophiajt sophiajt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@munyari @rust-highfive @sophiajt @bors