-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show how iterating over RangeTo
and RangeToInclusive
fails
#35771
Merged
bors
merged 1 commit into
rust-lang:master
from
matthew-piziak:range-inclusive-example-error
Aug 30, 2016
Merged
show how iterating over RangeTo
and RangeToInclusive
fails
#35771
bors
merged 1 commit into
rust-lang:master
from
matthew-piziak:range-inclusive-example-error
Aug 30, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Could we make the same style changes here as the other one, where the examples are split up, please? |
↓ done |
matthew-piziak
force-pushed
the
range-inclusive-example-error
branch
from
August 20, 2016 03:06
1c16bcf
to
c0fc1f6
Compare
Feedback on PR rust-lang#35701 seems to be positive, so this does the same thing for `RangeTo` and `RangeToInclusive`.
matthew-piziak
force-pushed
the
range-inclusive-example-error
branch
from
August 20, 2016 17:28
df76a69
to
2659198
Compare
Looks good! 👍 |
@bors: r+ rollup |
📌 Commit 2659198 has been approved by |
⌛ Testing commit 2659198 with merge f4596a1... |
💔 Test failed - auto-mac-64-opt-rustbuild |
@bors retry |
bors
added a commit
that referenced
this pull request
Aug 29, 2016
bors
added a commit
that referenced
this pull request
Aug 30, 2016
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 30, 2016
…ple-error, r=steveklabnik show how iterating over `RangeTo` and `RangeToInclusive` fails Feedback on PR rust-lang#35701 seems to be positive, so this does the same thing for `RangeTo` and `RangeToInclusive`.
bors
added a commit
that referenced
this pull request
Aug 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback on PR #35701 seems to be positive, so this does the same thing for
RangeTo
andRangeToInclusive
.